After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 666354 - Use overlay toolbar only in fullscreen mode
Use overlay toolbar only in fullscreen mode
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks: 666355
 
 
Reported: 2011-12-16 11:36 UTC by Florian Müllner
Modified: 2016-03-31 14:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
display-page: Use a less hackish way to center title (4.85 KB, patch)
2011-12-16 11:36 UTC, Florian Müllner 		committed Details | Review
display-page: Split out toolbar into its own class (6.07 KB, patch)
2011-12-16 11:36 UTC, Florian Müllner 		committed Details | Review
display-page: Use overlay toolbar only in fullscreen mode (8.19 KB, patch)
2011-12-16 11:36 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2011-12-16 11:36:24 UTC 
The autohiding behavior makes it hard to use when not in fullscreen, and
conflicts with current design patterns.
Comment 1 Florian Müllner 2011-12-16 11:36:27 UTC 
Created attachment 203650 [details] [review]
display-page: Use a less hackish way to center title

Currently we use two toolbars layed on top of each other, one for
the tool items on the left/right and one for the centered title.
The centering can be achieved with a size group, which feels a lot
cleaner.
Comment 2 Florian Müllner 2011-12-16 11:36:30 UTC 
Created attachment 203651 [details] [review]
display-page: Split out toolbar into its own class
Comment 3 Florian Müllner 2011-12-16 11:36:33 UTC 
Created attachment 203652 [details] [review]
display-page: Use overlay toolbar only in fullscreen mode

Triggering the autohidden toolbar is rather tricky when the window
is not fullscreened and conflicts with the design patter of hiding
the titlebar of maximized windows. So use a normal toolbar in windowed
mode and only switch to the autohiding overlay toolbar when in
fullscreen mode.
Comment 4 Marc-Andre Lureau 2012-01-03 13:45:42 UTC 
Review of attachment 203650 [details] [review]:

ack
Comment 5 Marc-Andre Lureau 2012-01-03 13:45:48 UTC 
Review of attachment 203651 [details] [review]:

ack
Comment 6 Marc-Andre Lureau 2012-01-03 13:45:53 UTC 
Review of attachment 203652 [details] [review]:

ack
Comment 7 Marc-Andre Lureau 2012-01-04 17:48:20 UTC 
Attachment 203650 [details] pushed as b23feea - display-page: Use a less hackish way to center title
Attachment 203651 [details] pushed as cf632bc - display-page: Split out toolbar into its own class
Attachment 203652 [details] pushed as d974f8a - display-page: Use overlay toolbar only in fullscreen mode
Comment 8 Marc-Andre Lureau 2012-01-04 18:30:32 UTC 
there is a problem with the last patch that I didn't notice first.

The event box doesn't recieve mouse event before switching to properties page. So fullscreen "auto-hide" is broken. It's weird as it seems like a gtk bug...
Comment 9 Marc-Andre Lureau 2012-01-04 20:51:18 UTC 
so it doesn't seem to be related to these patch, but somewhere else..