After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 666345 - Fix compilation error caused by wrong Automake rules.
Fix compilation error caused by wrong Automake rules.
Status: RESOLVED DUPLICATE of bug 665639
Product: gnome-bluetooth
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-bluetooth-general-maint@gnome.bugs
gnome-bluetooth-general-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2011-12-16 06:58 UTC by Shih-Yuan Lee (FourDollars)
Modified: 2011-12-16 16:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix compilation error caused by wrong Automake rules. (2.44 KB, patch)
2011-12-16 06:59 UTC, Shih-Yuan Lee (FourDollars) 		reviewed Details | Review

Description Shih-Yuan Lee (FourDollars) 2011-12-16 06:58:01 UTC 
I got source code from http://git.gnome.org/browse/gnome-bluetooth by `git clone http://git.gnome.org/browse/gnome-bluetooth`, and found it can not be compiled.
So I did this patch to fix it on top of 691225e963cdec181193d2bc79577601087b36f2 .
Comment 1 Shih-Yuan Lee (FourDollars) 2011-12-16 06:59:44 UTC 
Created attachment 203632 [details] [review]
Fix compilation error caused by wrong Automake rules.
Comment 2 Bastien Nocera 2011-12-16 11:52:39 UTC 
Review of attachment 203632 [details] [review]:

Changes with no explanations.

::: applet/Makefile.am
@@ +5,3 @@
 bluetooth_applet_SOURCES = main.c notify.h notify.c agent.h agent.c
 
+bluetooth_applet_LDADD = $(builddir)/libgnome-bluetooth-applet.la $(top_builddir)/lib/libgnome-bluetooth.la

It should already be dragged in by the deps of libgnome-bluetooth-applet.la

@@ +11,2 @@
 test_agentdialog_SOURCES = test-agentdialog.c notify.h notify.c
+test_agentdialog_LDADD = $(builddir)/libgnome-bluetooth-applet.la

Why did you remove the dep here?

@@ +16,2 @@
 AM_CFLAGS += $(APPLET_CFLAGS) $(WARN_CFLAGS) $(DISABLE_DEPRECATED) -DPKGDATADIR="\"$(pkgdatadir)\"" -DG_LOG_DOMAIN=\"BluetoothApplet\"
+AM_LDFLAGS = @APPLET_LIBS@

And add it (badly) here?

::: lib/Makefile.am
@@ +65,3 @@
 	-DPLUGINDIR=\"$(libdir)/gnome-bluetooth/plugins\" \
 	-DG_LOG_DOMAIN=\"Bluetooth\"
+AM_LDFLAGS = @LIBGNOMEBT_LIBS@

Why?

@@ +119,3 @@
 MAINTAINERCLEANFILES = Makefile.in
 
+bluetooth-client-glue.c bluetooth-client-glue.h: bluetooth-client.xml

What does this change?
Comment 3 Bastien Nocera 2011-12-16 16:29:18 UTC 

*** This bug has been marked as a duplicate of bug 665639 ***