After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 666315 - Start making use of libvirt-gconfig
Start making use of libvirt-gconfig
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: installer
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-12-15 19:21 UTC by Zeeshan Ali
Modified: 2016-03-31 13:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Start making use of libvirt-gconfig (19.41 KB, patch)
2011-12-15 19:21 UTC, Zeeshan Ali 		accepted-commit_now Details | Review
Start making use of libvirt-gconfig (19.59 KB, patch)
2011-12-15 23:22 UTC, Zeeshan Ali 		committed Details | Review

Description Zeeshan Ali 2011-12-15 19:21:13 UTC 
Instead of manually writing the libvirt's XML strings, we now make use of libvirt-gconfig to deal with the XML for us.
Comment 1 Zeeshan Ali 2011-12-15 19:21:21 UTC 
Created attachment 203601 [details] [review]
Start making use of libvirt-gconfig

Instead of manually writing the libvirt's XML strings, we now make use
of libvirt-gconfig to deal with the XML for us.

Also featured in this patch is separation of configuration XML authoring
from management of domain into a separate class/module. Now we can
remove the ugly namespace prefixes everywhere without compromising on
readability or confusing the compiler.
Comment 2 Marc-Andre Lureau 2011-12-15 20:11:20 UTC 
Review of attachment 203601 [details] [review]:

looks fine
Comment 3 Marc-Andre Lureau 2011-12-15 20:13:57 UTC 
(In reply to comment #1)
> Now we can
> remove the ugly namespace prefixes everywhere without compromising on
> readability or confusing the compiler.

I disagree. You don't need to express your opinion again here.
Comment 4 Zeeshan Ali 2011-12-15 21:05:07 UTC 
(In reply to comment #2)
> Review of attachment 203601 [details] [review]:
> 
> looks fine

Thanks for the quick review. I'll take this as an 'ack'.
Comment 5 Zeeshan Ali 2011-12-15 23:22:45 UTC 
Created attachment 203614 [details] [review]
Start making use of libvirt-gconfig

Instead of manually writing the libvirt's XML strings, we now make use
of libvirt-gconfig to deal with the XML for us.
Comment 6 Zeeshan Ali 2011-12-15 23:23:07 UTC 
Attachment 203614 [details] pushed as 1cb45c3 - Start making use of libvirt-gconfig