After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 666303 - broken video thumbnail handling?
broken video thumbnail handling?
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
2.14.x
Other Linux
: Normal normal
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks:
 
 
Reported: 2011-12-15 16:17 UTC by Michael Chudobiak
Modified: 2012-08-18 18:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
first screenshot (443.82 KB, image/png)
2011-12-15 16:19 UTC, Michael Chudobiak
  Details
screenshot after pressing PageDown (696.09 KB, image/png)
2011-12-15 16:20 UTC, Michael Chudobiak
  Details
Disable the separate code path for video icons in gthumb/gth-grid-view.c (681 bytes, patch)
2012-07-29 13:05 UTC, Bernd Feige
none Details | Review

Description Michael Chudobiak 2011-12-15 16:17:45 UTC
git master

If I navigate to a folder with a mix of photos and thumbnails, the video thumbnails seem to break the thumbnail display. Screenshots attached below.
Comment 1 Michael Chudobiak 2011-12-15 16:19:02 UTC
Created attachment 203587 [details]
first screenshot

Entering a folder with 75 photos + movies. Note the first movie is a black box, and everything after it is completely blank!
Comment 2 Michael Chudobiak 2011-12-15 16:20:09 UTC
Created attachment 203588 [details]
screenshot after pressing PageDown

After pressing PageDown, the next batch of thumbnails looks OK.
Comment 3 Deve 2012-06-18 12:13:58 UTC
The same bug is described on this site:

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=674112



To workaround you can remove /usr/share/thumbnails/totem.thumbnailer, then applications will show only thumbnails for images.



Actually gThumb writes good variables to totem thumbnailer. For example in my file:

%s = 128 
%u = 'file:///root/Wideo000.3gp' 
%o = '/tmp/.gnome_desktop_thumbnail.NPZZFW'

We gets:

/usr/bin/totem-video-thumbnailer -s 128 'file:///root/Wideo000.3gp' '/tmp/.gnome_desktop_thumbnail.NPZZFW'

Manually it works good. But when gThumb does it, file has 0 bytes.
Comment 4 Bernd Feige 2012-07-29 13:04:13 UTC
Hi Michael, Deve & Paolo,

exactly the same thing bugged me for a while, making gthumb practically unusable for me with my occasional videos mixed in my image directories. I'm currently using gthumb 3.0.0 on gentoo.

I've tracked this down to the separate generation of a pixbuf to display in gth-grid-view.c function _gth_grid_view_item_draw_thumbnail() (look for "if (! item->is_icon && item->is_video)"). I experimentally disabled this section and enabled the code path normally used for images ("if (! item->is_icon && item->is_image)") also for videos; this results in correct, usable display. Please note that I couldn't find a fault with actual thumbnail generation.

I attach a patch for this change. I know that this is only a proof-of-concept fix; My impression is that the separate treatment of video icons should be removed altogether. The video thumbnailer already adds the left and right movie patterns, so movies are readily discernible if icons are used as is. Otherwise, the separate treatment of video icons should be fixed throughout.

Cheers,
Bernd
Comment 5 Bernd Feige 2012-07-29 13:05:17 UTC
Created attachment 219838 [details] [review]
Disable the separate code path for video icons in gthumb/gth-grid-view.c
Comment 6 Paolo Bacchilega 2012-08-18 18:40:28 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.