GNOME Bugzilla – Bug 666247
teletextdec: add cache navigation functions
Last modified: 2018-11-03 13:09:59 UTC
At the moment you have to set the page/subpage directly and you can't simply zap through the cached pages or subpages. This patch add an "navigate" property with the values 0: show next cached page 1: show prev cached page 2: show next cached subpage 3: show prev cached subpage to make teletextdec more user-friendly.
Created attachment 203564 [details] [review] teletextdec.patch
A quick look through the patch: - could you please post a git fotmat-patch version, which will include your authorship information as well as correct indentation - the new property should be made an enum, rather than an int
Thomas, ping, did you rework on patch as per review comments ?
Thomas, ping
No, sorry. I don't use it anymore...
Closing this bug report as no further information has been provided. Please feel free to reopen this bug if you can provide the information asked for. Thanks!
Tobias: please don't close bugs with patches, just because the original author doesn't want to rework them. We might still want to take them.
Then the appropriate status is likely to be NEW.
Created attachment 311832 [details] [review] add cache navigation functions, port to 1.0 This patch requires https://bugzilla.gnome.org/show_bug.cgi?id=733819 first! - navigate property changed to enum
Created attachment 311925 [details] [review] add cache navigation functions, port to 1.0 use existing page_update instead of own routine
Created attachment 312003 [details] [review] add cache navigation functions, port to 1.0 Sorry, subpage scan was swapped. Hope it's the last patch now... ;-)
Any news here? Should I create a new diff against current git version?
Review of attachment 312003 [details] [review]: Please run gst-indent over your patches. This new property is not really a "property" per se. It seems like this is better handled by the GstNavigation interface than properties.
Created attachment 326238 [details] [review] add cache navigation functions patch against current git and run gst-indent
Hi Sebastian, thanks for looking at this. I never used the GstNavigation interface, so I can't say anything... :( Thomas
It is what is used for DVD menus for example, and most video sinks will e.g. send navigation events on mouse move/click, cursor keys, etc. Basically you would handle the navigation events in the element, and could map e.g. GST_NAVIGATION_COMMAND_LEFT See https://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-base-libs/html/gst-plugins-base-libs-gstnavigation.html
Thanks for the hint. Will try to rewrite the patch, but don't know when I've time for it.
Created attachment 326324 [details] [review] add cache navigation functions via navigation interface Ok, here is the first try to implement it via the gstnavigation interface. Hope I understand this right, at least it works here like before via the properties version. GST_NAVIGATION_COMMAND_UP: show next cached page GST_NAVIGATION_COMMAND_DOWN: show prev cached page GST_NAVIGATION_COMMAND_RIGHT: show next cached subpage GST_NAVIGATION_COMMAND_LEFT: show prev cached subpage
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/54.