GNOME Bugzilla – Bug 666192
Random PIN code is used even if I choose a fixed one
Last modified: 2011-12-18 10:46:41 UTC
Step to reproduce: 1) start to pair my phone 2) choose "0000" or another fixed PIN or write a PIN in the text entry 3) press "Next" 4) a random PIN is shown and used instead of what I chose in step 2 The attached patch does two things: 1) honour the choice of fixed PIN or user input 2) give the user a feedback for what is read from the PIN database (if it's a maximum length then it is enforced by the text entry; if it's one of "0000", "1111", "1234" or "NULL" then the corresponding radio button is selected else it's shown in the text entry and can be modified)
Created attachment 203512 [details] [review] Fix non random PIN codes and show data from PIN database
Review of attachment 203512 [details] [review]: "change" The patch looks good though invasive. If you're tested this thoroughly, I'm happy for you to commit it to master. ::: wizard/main.c @@ +149,3 @@ target_ssp = FALSE; + /* Only random PIN codes need to be showed; other codes are meant for shown.
Comment on attachment 203512 [details] [review] Fix non random PIN codes and show data from PIN database I'm going to push the changes separately.
Created attachment 203785 [details] [review] wizard: do not use a random PIN if user choose a fixed one User input was used only in the select_device_changed() callback.