After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 666086 - Read & fill 1 line of unattended files at time
Read & fill 1 line of unattended files at time
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: installer
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-12-13 14:03 UTC by Zeeshan Ali
Modified: 2016-03-31 14:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Read & fill 1 line of unattended files at time (3.65 KB, patch)
2011-12-13 14:03 UTC, Zeeshan Ali 		committed Details | Review

Description Zeeshan Ali 2011-12-13 14:03:21 UTC 
This is the only easy way to ensure we don't end-up getting a variable split in separate reads and therefore not getting substituted.
Comment 1 Zeeshan Ali 2011-12-13 14:03:22 UTC 
Created attachment 203339 [details] [review]
Read & fill 1 line of unattended files at time

This is the only easy way to ensure we don't end-up getting a variable
split in separate reads and therefore not getting substituted.
Comment 2 Marc-Andre Lureau 2011-12-13 14:21:01 UTC 
Review of attachment 203339 [details] [review]:

see comment, ack otherwise

::: src/unattended-installer.vala
@@ +292,3 @@
                                                              cancellable);
+        var data_stream = new DataInputStream (input_stream);
+        data_stream.newline_type = DataStreamNewlineType.ANY;

why not setting it here to the expected value?
Comment 3 Zeeshan Ali 2011-12-13 14:29:47 UTC 
(In reply to comment #2)
> Review of attachment 203339 [details] [review]:
> 
> see comment, ack otherwise
> 
> ::: src/unattended-installer.vala
> @@ +292,3 @@
>                                                               cancellable);
> +        var data_stream = new DataInputStream (input_stream);
> +        data_stream.newline_type = DataStreamNewlineType.ANY;
> 
> why not setting it here to the expected value?

Don't see a need to be strict on parsing as its pretty easy to mess-up the CRLF when editting the template file on Linux (I'm sure I'll be doing that mistake and then waste hours finding out why unattended install isn't working anymore :)).
Comment 4 Zeeshan Ali 2011-12-16 17:09:31 UTC 
ACK?
Comment 5 Marc-Andre Lureau 2011-12-16 18:57:36 UTC 
ack
Comment 6 Zeeshan Ali 2011-12-16 22:51:52 UTC 
Attachment 203339 [details] pushed as f17f7d1 - Read & fill 1 line of unattended files at time