Created attachment 203306 [details] [review]
Specify language for Windows 2008 express install

Review of attachment 203306 [details] [review]:

::: data/win2k8.xml
@@ +52,3 @@
       </SetupUILanguage>
+      <SystemLocale>BOXES_LANG</SystemLocale>
+      <UILanguage>EN-US</UILanguage>

although I cannot say much about the patch, this line strikes me, how come you set language above for Setup and not here?

(In reply to comment #2)
> Review of attachment 203306 [details] [review]:
> 
> ::: data/win2k8.xml
> @@ +52,3 @@
>        </SetupUILanguage>
> +      <SystemLocale>BOXES_LANG</SystemLocale>
> +      <UILanguage>EN-US</UILanguage>
> 
> although I cannot say much about the patch, this line strikes me, how come you
> set language above for Setup and not here?

Same reason as for win7: setup doesn't like any value other than en-US.

 but it looks like you set it for setup, not the other way around

(In reply to comment #4)
>  but it looks like you set it for setup, not the other way around

I set it up for every thing for which setup accepts it, except for one that it doesn't.

Can you point to any reference that says what value are customizable and which are not?

(In reply to comment #6)
> Can you point to any reference that says what value are customizable and which
> are not?

According to the docs on MSDN everything is customizable AFAICT, whats actually possible is another thing.

Ack?

(In reply to comment #8)
> Ack?

I would prefer we find a reference documentation that says what is really possible before, unless we have something broken right now.

(In reply to comment #9)
> (In reply to comment #8)
> > Ack?
> 
> I would prefer we find a reference documentation that says what is really
> possible before, unless we have something broken right now.

I don't see any reason to not already use the correct value where they are known to work as expected but up to you. I already searched through the docs that I could find on the subject and found nothing that would explain this. If you can help with that, that would be awesome!

There is actually quite a lot of documentation on the subect.
http://technet.microsoft.com/en-us/library/cc749455%28v=ws.10%29

the possible combinations for 2k8 are listed in: http://technet.microsoft.com/en-us/library/cc722435%28v=ws.10%29

This may require installation of the language packs, there are various methods to do so, and other methods during setup:
http://technet.microsoft.com/en-us/library/cc748922%28v=ws.10%29

The link to pack download page:
http://www.microsoft.com/en-us/download/details.aspx?id=22681

In the meantime, the proposed patch doesn't seem to be of any help.

Review of attachment 203306 [details] [review]:

nack

For what it's worth, en-US does not seem to work on a Russian win7 iso (or at least something language-related is not working as the installer asks me about it).

This has been handled by libosinfo for while now and AFAIK Christophe already solved this with language maps in there. Closing..