Bug 666030 - UI for specifying product key for Windows XP & 2003
UI for specifying product key for Windows XP & 2003
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: installer
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2011-12-12 21:31 UTC by Zeeshan Ali (Khattak)
Modified: 2016-03-31 13:55 UTC (History)
0 users

See Also:
GNOME target: ---
GNOME version: ---

Attachments
UI for specifying product key for Windows XP & 2003 (20.43 KB, patch)
2011-12-12 21:31 UTC, Zeeshan Ali (Khattak) 		reviewed Details | Diff | Review
UI for specifying product key for Windows XP & 2003 (20.54 KB, patch)
2011-12-12 23:33 UTC, Zeeshan Ali (Khattak) 		committed Details | Diff | Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Description Zeeshan Ali (Khattak) 2011-12-12 21:31:05 UTC 
Add UI to wizard's setup page for specifying product key for Windows XP & 2003.
Comment 1 Zeeshan Ali (Khattak) 2011-12-12 21:31:07 UTC 
Created attachment 203299 [details] [review]
UI for specifying product key for Windows XP & 2003

Product keys are not required by recent Windows (Vista, 7 and 2008).
Comment 2 Marc-Andre Lureau 2011-12-12 22:48:32 UTC 
Review of attachment 203299 [details] [review]:

::: src/unattended-installer.vala
@@ +288,3 @@
         while ((bytes_read = yield input_stream.read_async (buffer, Priority.DEFAULT, cancellable)) > 0) {
             var str = ((string) buffer).substring (0, (long) bytes_read);
+            str = convert_unattended_data (str);

convert? -> fill?

::: src/winxp-installer.vala
@@ +48,3 @@
+        var font_desc = Pango.FontDescription.from_string ("monospace");
+        // FIXME: According to Benjamin Otte, this function (being an override) can have unintended side-affects so
+        label.halign = Gtk.Align.START;

It should. look at how it's done for other widgets, it's quite simple
Comment 3 Zeeshan Ali (Khattak) 2011-12-12 23:33:43 UTC 
Created attachment 203307 [details] [review]
UI for specifying product key for Windows XP & 2003

Product keys are not required by recent Windows (Vista, 7 and 2008).
Comment 4 Marc-Andre Lureau 2011-12-12 23:48:13 UTC 
Review of attachment 203307 [details] [review]:

ack
Comment 5 Zeeshan Ali (Khattak) 2011-12-13 13:25:04 UTC 
Attachment 203307 [details] pushed as 2a8c937 - UI for specifying product key for Windows XP & 2003
Note You need to log in before you can comment on or make changes to this bug.