After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 665996 - Minor changes to existing Assistants
Minor changes to existing Assistants
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: User Interface General
git-master
Other Linux
: Normal enhancement
: ---
Assigned To: Christian Stimming
Geert Janssens
Depends on:
Blocks:
 
 
Reported: 2011-12-12 13:13 UTC by Bob
Modified: 2018-06-29 23:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Change some druid entries to assistant (7.49 KB, patch)
2011-12-12 13:14 UTC, Bob
accepted-commit_now Details | Review

Description Bob 2011-12-12 13:13:29 UTC
The enclosed patch changes some existing assistants which had 'druid' in some comments and functions to 'assistant'. This was a left over from changing them from druid to assistants.

Also there are two fixes for the hierarchy and qif assistants to bring up the save as dialog when these two assistants are started from the 'New User' dialog.

Note. The hierarchy fix should fix bug 658247 if accepted.
Comment 1 Bob 2011-12-12 13:14:18 UTC
Created attachment 203248 [details] [review]
Change some druid entries to assistant
Comment 2 Christian Stimming 2011-12-12 15:23:32 UTC
Comment on attachment 203248 [details] [review]
Change some druid entries to assistant

In src/gnome/dialog-new-user.c, you insert  gnc_ui_file_access_for_save_as() -- is this intended?
Comment 3 Bob 2011-12-12 16:33:53 UTC
(In reply to comment #2)
> (From update of attachment 203248 [details] [review])
> In src/gnome/dialog-new-user.c, you insert  gnc_ui_file_access_for_save_as() --
> is this intended?

Yes, the heirarchy assistant is started with a callback so when it finishes there is a procedure 'after_hierarchy_assistant' that runs and this is where I fire the save as dialog for a new user.
Comment 4 Mike Evans 2011-12-16 14:37:01 UTC
Since this also fixes bug 658247 I've commited that part of the patch separately to trunk as r21732.
Comment 5 Mike Evans 2011-12-16 14:58:02 UTC
Remainder of the patch commited to trunk as r21733

Thank you Bob for the patch.
Comment 6 John Ralls 2018-06-29 23:03:42 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=665996. Please update any external references or bookmarks.