After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 665894 - [0.11] MPEG PS Demuxer seeking is really slow on VBR files
[0.11] MPEG PS Demuxer seeking is really slow on VBR files
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.11.x
Other Mac OS
: Normal normal
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 665886
Blocks:
 
 
Reported: 2011-12-10 00:33 UTC by Matej Knopp
Modified: 2012-02-20 15:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to add binary search for seeking (2.68 KB, patch)
2011-12-10 00:33 UTC, Matej Knopp 		none Details | Review
Updated patch to add max recursion check (4.22 KB, patch)
2011-12-11 03:54 UTC, Matej Knopp 		none Details | Review
Use binary search for seeking (4.30 KB, patch)
2011-12-19 02:25 UTC, Matej Knopp 		none Details | Review

Description Matej Knopp 2011-12-10 00:33:21 UTC 
Created attachment 203176 [details] [review]
Patch to add binary search for seeking

When the bitrate varies too much the demuxer offset guess can be too far off. Tested with 2.8 GB vob file some seeks took more than 1.5sec just to find the right offset. Attached patch implements the seeking using binary search. During my testing with same file it reduced the seek time to less than 10ms.
Comment 1 Matej Knopp 2011-12-10 04:00:51 UTC 
Note - the code could use a recursion counter so that it doesn't overflow on malformed stream. Will fix later.
Comment 2 Tim-Philipp Müller 2011-12-10 11:37:01 UTC 
This looks like something that should go into master and then be merged into 0.11.
Comment 3 Matej Knopp 2011-12-11 03:54:21 UTC 
Created attachment 203203 [details] [review]
Updated patch to add max recursion check

The patch is for 0.11 (which is what I develop against). If you want to apply the patch I can provide version for 0.10 if someone is willing to test it - I don't have any application to test it with that links with 0.10.
Comment 4 Matej Knopp 2011-12-19 02:25:02 UTC 
Created attachment 203816 [details] [review]
Use binary search for seeking

fix uninitialized variable
Comment 5 Vincent Penquerc'h 2012-01-17 13:44:21 UTC 
Totem ought to be a good 0.10 test for that FWIW.
Comment 6 Matej Knopp 2012-01-17 19:10:30 UTC 
I'm not sure I feel like building totem on OS X.
Comment 7 Sebastian Dröge (slomo) 2012-01-27 15:58:17 UTC 
gst-plugins-base/tests/examples/seek is a good test for seeking stuff ;)
Comment 8 Wim Taymans 2012-02-20 15:18:35 UTC 
seem to be commited