After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 665882 - gdkpixbufsink: "pixel-aspect-ratio" is the inverse of what it should be
gdkpixbufsink: "pixel-aspect-ratio" is the inverse of what it should be
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.x
Other Linux
: Normal normal
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-12-09 18:12 UTC by mike morrison
Modified: 2011-12-11 18:46 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description mike morrison 2011-12-09 18:12:35 UTC
in the messages that gdkpixbufsink puts on the bus ("pixbuf" and "preroll-pixbuf"), the "pixel-aspect-ratio" field is set to denominator/numerator instead of numerator/denominator.

this bug is on lines 274 and 347 of gstgdkpixbufsink.c:

http://cgit.freedesktop.org/gstreamer/gst-plugins-good/tree/ext/gdk_pixbuf/gstgdkpixbufsink.c
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2011-12-11 17:59:19 UTC
Could you please make a patch?
Comment 2 Tim-Philipp Müller 2011-12-11 18:46:43 UTC
Fixed, thanks for the bug report!

 commit 8aebe194aa6d9bb01aeb53538c4ada54d3c19f1d
 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
 Date:   Sun Dec 11 18:40:31 2011 +0000

    gdkpixbufsink: fix inverted pixel-aspect-ratio
    
    Spotted by Mike Morrison.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=665882