After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 665872 - jackaudiosink, jackaudiosrc: add "client-name" property
jackaudiosink, jackaudiosrc: add "client-name" property
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.30
Other Linux
: Normal enhancement
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-12-09 15:32 UTC by Nicolas BARON
Modified: 2011-12-09 15:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
This is the patch against version gst-plugins-good-0.10.30 (5.21 KB, patch)
2011-12-09 15:32 UTC, Nicolas BARON
none Details | Review

Description Nicolas BARON 2011-12-09 15:32:34 UTC
Created attachment 203152 [details] [review]
This is the patch against version gst-plugins-good-0.10.30

When launched with gst-launch, it is impossible to set the Jack client name of GStreamer's Jack plugins.
It is particularly difficult to work when there are several instances of GStreamer using the same Jack server, and whose client names are gst-launch-0.10-xx, as the plugin takes its name from g_get_application_name ().

With this patch, it is possible to set a custom name with the new property "client-name".
Comment 1 Tim-Philipp Müller 2011-12-09 15:55:34 UTC
Why not, thanks for the patch. Would be nice if it was in git format-patch format next time :)

Bit unfortunate that pulseaudio has this as "client" property, but I think "client-name" is better anyway, so should probably just rename the pulse one in 0.11:

 commit 2e078fa556018c5c2f3c13d54aa6614622e5ecac
 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
 Date:   Fri Dec 9 15:50:28 2011 +0000

    jack: don't leak client name when freeing the element
    
    And add gtk-doc chunks for the new property.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=665872

 commit 92cfb335cde7386b53c76e030603a0897429a6ff
 Author: Nicolas Baron <hoggins@radiom.fr>
 Date:   Fri Dec 9 15:45:03 2011 +0000

    jack: add "client-name" property to jackaudiosink and jackaudiosrc
    
    https://bugzilla.gnome.org/show_bug.cgi?id=665872