After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 665869 - link libgdprivate against libm (uses floor(3))
link libgdprivate against libm (uses floor(3))
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-12-09 13:34 UTC by Frederic Peters
Modified: 2011-12-10 09:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
link libgdprivate against libm (uses floor(3)) (1.04 KB, patch)
2011-12-09 13:36 UTC, Frederic Peters
accepted-commit_now Details | Review

Description Frederic Peters 2011-12-09 13:34:45 UTC
src/lib/gd-tagged-entry.c and src/lib/gd-utils.c both uses floor(3) but the
libgdprivate library is not set to link against libm, this can cause the linker
to abort like this:

  CCLD   gd-tracker-gdata-miner
  GISCAN Gd-1.0.gir
./.libs/libgdprivate-1.0.so: error: undefined reference to 'floor'
collect2: ld returned 1 exit status
Comment 1 Frederic Peters 2011-12-09 13:36:00 UTC
Created attachment 203147 [details] [review]
link libgdprivate against libm (uses floor(3))
Comment 2 Cosimo Cecchi 2011-12-09 16:02:39 UTC
Comment on attachment 203147 [details] [review]
link libgdprivate against libm (uses floor(3))

Thanks, looks good.
Comment 3 Frederic Peters 2011-12-10 09:47:26 UTC
Pushed, thanks.