After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 665856 - Best fit is too tall
Best fit is too tall
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
3.2.x
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-12-09 10:29 UTC by Torquil Macdonald Sørensen
Modified: 2012-11-12 09:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
One-page PDF (11.73 KB, application/pdf)
2011-12-10 19:16 UTC, Torquil Macdonald Sørensen 		  Details
small patch to fix the issue. (1.39 KB, patch)
2012-11-05 20:17 UTC, José Aliste 		committed Details | Review

Description Torquil Macdonald Sørensen 2011-12-09 10:29:34 UTC 
Hi!

When using "Best fit" in "continuous view mode", the PDF page is too tall by a few millimeters. I.e. the vertical scrollbar is still present because it is still possible to move the page vertically by a tiny amount. It is a bit strange that even though the vertical scrollbar is visible and moves the page up and down by this tiny amount, the whole page is visible at all times.

IMHO, "best fit" should mean the largest possible view without any scrollbar need. I.e., "best fit" should make the page so small that horisontal and vertical scrollbars automatically disappear.

Best regards
Torquil Sørensen
Comment 1 José Aliste 2011-12-09 11:46:24 UTC 
Hi, thanks for your interest in evince. Could you please explain more? ARe you talking about a document with only one page? Otherwise, in "best fit continuous mode" you should always get a scrollbar so you can change pages... And with one page in the same mode, I don't get a scrollbar, so if possible attach a pdf file so we can reproduce the issue.
Comment 2 Torquil Macdonald Sørensen 2011-12-10 19:16:07 UTC 
Created attachment 203189 [details]
One-page PDF
Comment 3 Torquil Macdonald Sørensen 2011-12-10 19:17:40 UTC 
(In reply to comment #1)
> Hi, thanks for your interest in evince. Could you please explain more? ARe you
> talking about a document with only one page? Otherwise, in "best fit continuous
> mode" you should always get a scrollbar so you can change pages... And with one
> page in the same mode, I don't get a scrollbar, so if possible attach a pdf
> file so we can reproduce the issue.

Hi!

Yes I meant one-page PDF documents, in continuous mode and "best fit". The vertical scrollbar is still present and allows me to move the document a tiny amount up and down. I attached a one-page example PDF.
Comment 4 José Aliste 2011-12-10 21:15:58 UTC 
confirming
Comment 5 José Aliste 2012-11-05 20:17:49 UTC 
Created attachment 228186 [details] [review]
small patch to fix the issue.

Carlos, here is a small patch that would fix the issue. I don't understand why the zoom is slightly different (before the patch), in continuous and single page mode.
Comment 6 Carlos Garcia Campos 2012-11-07 16:57:37 UTC 
I don't know either.
Comment 7 Carlos Garcia Campos 2012-11-11 11:13:42 UTC 
Review of attachment 228186 [details] [review]:

Ok, push the patch to git master only, please. Thanks!
Comment 8 José Aliste 2012-11-12 09:43:34 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 9 José Aliste 2012-11-12 09:43:35 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.