After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 665853 - Use new folks API to ensure personas
Use new folks API to ensure personas
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.33.x
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
empathy-maint
: 665207 (view as bug list)
Depends on: 665376
Blocks: 665038
 
 
Reported: 2011-12-09 09:42 UTC by Guillaume Desmottes
Modified: 2011-12-14 09:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use tpf_persona_dup_for_contact() (1.63 KB, patch)
2011-12-09 16:27 UTC, Guillaume Desmottes 		committed Details | Review
Deal with empathy_create_individual_from_tp_contact() returning NULL (1.66 KB, patch)
2011-12-09 16:27 UTC, Guillaume Desmottes 		committed Details | Review
empathy_contact_get_persona: use tpf_persona_dup_for_contact() (2.55 KB, patch)
2011-12-09 16:27 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2011-12-09 09:42:59 UTC 
Once bug #665376 has been merged and released we should make sure to use it.
Comment 1 Guillaume Desmottes 2011-12-09 11:29:12 UTC 
*** Bug 665207 has been marked as a duplicate of this bug. ***
Comment 2 Guillaume Desmottes 2011-12-09 16:27:50 UTC 
Created attachment 203155 [details] [review]
use tpf_persona_dup_for_contact()
Comment 3 Guillaume Desmottes 2011-12-09 16:27:53 UTC 
Created attachment 203156 [details] [review]
Deal with empathy_create_individual_from_tp_contact() returning NULL

Shouldn't really happen in practice but better to be safe than sorry.
Comment 4 Guillaume Desmottes 2011-12-09 16:27:56 UTC 
Created attachment 203157 [details] [review]
empathy_contact_get_persona: use tpf_persona_dup_for_contact()

We can finally get rid of this horrible code iterating over all the
individuals. \o/
Comment 5 Guillaume Desmottes 2011-12-09 16:28:59 UTC 
Those patches can't be merged yet (we need a folks release and bump the dep) but nothing is blocking their review.
Comment 6 Philip Withnall 2011-12-12 12:17:15 UTC 
Review of attachment 203155 [details] [review]:

Looks good to me.
Comment 7 Philip Withnall 2011-12-12 12:18:51 UTC 
Review of attachment 203156 [details] [review]:

Looks good to me.
Comment 8 Philip Withnall 2011-12-12 12:20:53 UTC 
Review of attachment 203157 [details] [review]:

Kill it! \o/
Comment 9 Guillaume Desmottes 2011-12-14 09:57:58 UTC 
Merged to master.

Attachment 203155 [details] pushed as eebfb2b - use tpf_persona_dup_for_contact()
Attachment 203156 [details] pushed as 844b932 - Deal with empathy_create_individual_from_tp_contact() returning NULL
Attachment 203157 [details] pushed as aa80250 - empathy_contact_get_persona: use tpf_persona_dup_for_contact()