GNOME Bugzilla – Bug 665732
vapigen fails to resolve aliased callback types
Last modified: 2018-05-22 14:16:21 UTC
I'm trying to generate Vala bindings for libsignon-glib [0]. I've uploaded the .gir file to http://pastebin.com/76wcPHGj in case you want to check it. vapigen cannot resolve a few callback types, for instance: ========= Signon-1.0.gir:478.79-478.79: error: The type name `IdentityReferenceAddedCb' could not be found c:type="SignonIdentityReferenceAddedCb"/> ^ ========= This is because IdentityReferenceAddedCb is an alias for IdentityVoidCb, and apparently vapigen does not support aliases for callback types. [0]: http://bazaar.launchpad.net/~webcredentials-team/opensesame-libsignon-glib/trunk/files
Created attachment 202996 [details] [review] Support alias for callback types Here is a patch which seems to work fine for me. This adds the following lines into the .vapi file: ========== public delegate void IdentityReferenceAddedCb (Signon.Identity self, GLib.Error error); [CCode (cheader_filename = "Signon-1.0.h", instance_pos = 2.9)] public delegate void IdentityReferenceRemovedCb (Signon.Identity self, GLib.Error error); [CCode (cheader_filename = "Signon-1.0.h", instance_pos = 2.9)] ========== Which seem correct to me. Note, however, that I'm a complete newbie to Vala so please review the patch carefully.
I hit the same problem while trying to generate a VAPI file for libsignon-glib, using the vala master from yesterday, and Alberto's patch allows me to generate a working binding. Is the approach used in the patch OK?
Review of attachment 202996 [details] [review]: Thanks for the patch. The approach is right, except: 1) It doesn't take in account thrown errors 2) Also Node.array_length_parameters, Node.closure_parameters, Node.destroy_parameters and Node.return_array_length_idx must be copied
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/vala/issues/260.