After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 665723 - Conformance tests failed (snippets, pipeline_uniforms)
Conformance tests failed (snippets, pipeline_uniforms)
Status: RESOLVED FIXED
Product: cogl
Classification: Platform
Component: general
1.9.x
Other All
: Normal normal
: ---
Assigned To: Cogl maintainer(s)
Cogl maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-12-07 10:01 UTC by Fan, Chun-wei
Modified: 2011-12-07 19:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
test-utils: Add some fuzz to the pixel comparison routine (3.21 KB, patch)
2011-12-07 12:42 UTC, Neil Roberts 		none Details | Review

Description Fan, Chun-wei 2011-12-07 10:01:03 UTC 
Hi,

The following tests failed on both Linux and Windows:

test_cogl_pipeline_uniforms
test_cogl_snippets

with a message like the following (on both Windows and Linux):
ERROR:..\..\..\tests\conform\test-utils.c:96:???: assertion failed (screen_pixel
 == intended_pixel): ("#ff007f" == "#ff0080")

Disabling that assertion check would make the tests pass, but I doubt doing so is good-might defeat the purposes of those tests.

Thank you, and God Bless!
Comment 1 Neil Roberts 2011-12-07 12:42:08 UTC 
I guess this is because the test is storing 0.5 to the color from the shader and it's up to the hardware whether it rounds this to 0x7f or 0x80. Maybe we should add some fuzz to the comparison.
Comment 2 Neil Roberts 2011-12-07 12:42:36 UTC 
Created attachment 202984 [details] [review]
test-utils: Add some fuzz to the pixel comparison routine

When comparing a pixel, the comparison routines now allow each
component to be off by +/- 1. This is to compensate for varying
rounding across drivers.
Comment 3 Fan, Chun-wei 2011-12-07 15:54:42 UTC 
Hi,

I think this update worked for me on the nVidia NVS 42000 graphics on my laptop.

Thanks-did not expect this to be a driver issue.

God Bless!
Comment 4 Neil Roberts 2011-12-07 19:13:24 UTC 
Thanks for looking at this. I've pushed the patch as 4c8966122f0