GNOME Bugzilla – Bug 665616
Add hide-titlebar-when-maximized setting
Last modified: 2011-12-15 15:33:06 UTC
New applications designed by the design team request that titlebars should be hidden when windows are maximized[0]. The designers think that applications need to be designed with this maximization state in mind, so we cannot just remove titlebars on all maximized windows - for that purpose, add a GtkSetting which allows applications to request from the window manager that titlebars should be hidden during maximization. [0] https://live.gnome.org/GnomeOS/Design/Whiteboards/WindowStates
Created attachment 202856 [details] [review] settings: Add hide-titlebar-when-maximized setting For maximized windows, titlebars cannot be used to reposition or scale the window, so if an application does not use it to convey useful information (other than the application name), the screen space occupied by titlebars could be put to better use. Add a new application setting which requests from the window manager to hide titlebars when windows are maximized to account for this.
Created attachment 202857 [details] [review] demo: Add test for hide-titlebar-when-maximized Add an additional option to the appwindow demo to test the new gtk-hide-titlebar-when-maximized setting.
Created attachment 202866 [details] [review] window: Add hide-titlebar-when-maximized property Talked with Matthias on IRC, we agreed on using a Window property instead.
Created attachment 202867 [details] [review] demo: Add test for hide-titlebar-when-maximized Obvious patch update.
Created attachment 202868 [details] [review] window: Add hide-titlebar-when-maximized property *) Make sure the X11 property is set when the window is initially mapped
Review of attachment 202868 [details] [review]: ::: gtk/gtkwindow.c @@ +3083,3 @@ + g_return_if_fail (GTK_IS_WINDOW (window)); + + if (!window->priv->type == GTK_WINDOW_TOPLEVEL) This looks wierd. I'd strongly recommend to go with != Do the window type checks add anything, anyway ? We could just do away with them and live with the fact that some people might set a few ignored properties on non-toplevel windows...
Review of attachment 202867 [details] [review]: This one looks fine
Created attachment 202874 [details] [review] window: Add hide-titlebar-when-maximized property (In reply to comment #6) > Do the window type checks add anything, anyway ? Not really, no. > We could just do away with them and live with the fact that some people > might set a few ignored properties on non-toplevel windows... Sure, I removed the toplevel check from the gtk part.
Review of attachment 202874 [details] [review]: Looks fine now, thanks.
Attachment 202867 [details] pushed as 3b0a9c5 - demo: Add test for hide-titlebar-when-maximized Attachment 202874 [details] pushed as 4f8f8fe - window: Add hide-titlebar-when-maximized property