After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 665529 - [0.11] GstPad push_sticky returns wrong value
[0.11] GstPad push_sticky returns wrong value
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.11.x
Other All
: Normal major
: 0.11.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-12-04 06:35 UTC by Matej Knopp
Modified: 2012-02-18 20:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (725 bytes, patch)
2011-12-04 06:35 UTC, Matej Knopp 		none Details | Review

Description Matej Knopp 2011-12-04 06:35:03 UTC 
Created attachment 202738 [details] [review]
patch

static gboolean
push_sticky (GstPad * pad, PadEvent * ev, gpointer user_data)
{
 ....
  return *data != GST_FLOW_OK;
}

the last line should be data == GST_FLOW_OK, otherwise it returns false when sending the event succeeds, preventing subsequent sticky event to be sent (events_foreach breaks if !ret)
Comment 1 Wim Taymans 2011-12-05 16:12:01 UTC 
commited, thanks.