After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 665526 - prefer native threads on win32
prefer native threads on win32
Status: RESOLVED FIXED
Product: libxml2
Classification: Platform
Component: general
git master
Other Windows
: Normal minor
: ---
Assigned To: Daniel Veillard
libxml QA maintainers
Depends on:
Blocks:
 
 
Reported: 2011-12-04 02:29 UTC by Sam Thursfield
Modified: 2012-05-09 10:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch: configure.in - prefer win32 native threads when available (1.80 KB, patch)
2011-12-04 02:29 UTC, Sam Thursfield
none Details | Review

Description Sam Thursfield 2011-12-04 02:29:31 UTC
Created attachment 202736 [details] [review]
patch: configure.in - prefer win32 native threads when available

I came up with patch originally to work around https://bugzilla.gnome.org/show_bug.cgi?id=599241 , however it turns out this has a fix

It still seems like it would be better to use the native Win32 threads API when available rather than using it through the pthread wrapper, since the code is already there.

This has been suggested before:
https://bugzilla.gnome.org/show_bug.cgi?id=593857
https://bugzilla.gnome.org/show_bug.cgi?id=588352
Comment 1 André Klapper 2012-02-02 21:07:59 UTC
Comment on attachment 202736 [details] [review]
patch: configure.in - prefer win32 native threads when available

[Setting "patch" flag and correcting mime type]
Comment 2 Daniel Veillard 2012-05-09 10:49:11 UTC
Thanks André for the bugilla work, it does help !!!

Sam, yes I agree that going though native thread support when available
and pthreads are not explicitely asked for sounds a better option.
The patch looks sensible, there is just a bug
  if test -z "THREADS_W32"; then
should be
  if test -z "$THREADS_W32"; then
to avoid disabling thread support on all non-Windows targets, but once fixed
that works fine :-)
So I applied the patch and commited after that small fix :)

  http://git.gnome.org/browse/libxml2/commit/?id=115581ae2d3e35ddb7c43c50aacfa98193be6b72

 thanks !

Daniel