After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 665484 - [WEB] Create"about:" page with information about the browser
[WEB] Create"about:" page with information about the browser
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
polish
Depends on:
Blocks:
 
 
Reported: 2011-12-03 14:57 UTC by Xan Lopez
Modified: 2013-12-17 15:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add an about: handler (4.70 KB, patch)
2013-12-15 18:38 UTC, William Jon McCann 		reviewed Details | Review
Add an about: handler (4.97 KB, patch)
2013-12-16 17:22 UTC, William Jon McCann 		committed Details | Review

Description Xan Lopez 2011-12-03 14:57:20 UTC 
Name, version, version of WebKitGTK+, license, etc.

Might allow us to just remove the About item in the help menu.
Comment 1 William Jon McCann 2013-12-15 18:38:11 UTC 
Created attachment 264240 [details] [review]
Add an about: handler
Comment 2 Reinout van Schouwen 2013-12-15 23:19:32 UTC 
Might I suggest to update the contributors list of the About dialog while you're at it?
Comment 3 William Jon McCann 2013-12-16 17:22:01 UTC 
Created attachment 264307 [details] [review]
Add an about: handler

Use a cleaner way to get the icon
Comment 4 Gustavo Noronha (kov) 2013-12-17 15:20:13 UTC 
Review of attachment 264240 [details] [review]:

This is handling only about:, right? Maybe it should also handle about:epiphany and about:web.

::: embed/ephy-about-handler.c
@@ +273,3 @@
+  version = g_strdup_printf (_("Version %s"), VERSION);
+
+  img_path = g_build_filename (DATADIR, "/icons/gnome/256x256/apps/web-browser.png", NULL);

We should have these as GResources! Then we can just use them in resource:// urls or something.
Comment 5 William Jon McCann 2013-12-17 15:53:20 UTC 
Attachment 264307 [details] pushed as f389331 - Add an about: handler