GNOME Bugzilla – Bug 665421
Port number explanations do not appear translated in the account editor
Last modified: 2011-12-02 20:32:21 UTC
Created attachment 202642 [details] Screenshot of the problem On the Receiving Email and Sending Email pages of the account editor, you can set the port number of the servers. When you click the arrow next to the Port box, you can see a short explanation of the default ports, like "IMAP default port" "IMAP over SSL" etc, which do not appear translated, despite they are translated in the po file. This is because the strings are parts of static arrays, and gettext() is never called on them when they are actually used.
Created attachment 202643 [details] [review] Localize port numbers with the rest of the provider strings This patch worked for me in jhbuild.
What does P_() do differently from _() ? Just curious. Hard to Google these things. :)
P_() is a macro around dgettext(), defined a in the same function: http://git.gnome.org/browse/evolution-data-server/tree/camel/camel-provider.c#n246
Oh hey look at that. No wonder Google came up empty. Patch approved for gnome-3-2 and master branches. Can't commit it myself right at the moment, but if you have commit rights then go ahead.
Review of attachment 202643 [details] [review]: Pushed, thanks for the quick reply!
Review of attachment 202643 [details] [review]: Set status for real :)