After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 665420 - arrow: make rendering of arrows possible with CSS
arrow: make rendering of arrows possible with CSS
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Class: GtkStyleContext
3.6.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 686986 (view as bug list)
Depends on:
Blocks: 685416
 
 
Reported: 2011-12-02 17:50 UTC by Cosimo Cecchi
Modified: 2014-07-10 03:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
stylecontext: add GTK_STYLE_CLASS_ARROW (1.43 KB, patch)
2011-12-02 17:50 UTC, Cosimo Cecchi 		committed Details | Review
stylecontext: always add the ARROW style class when rendering an arrow (1.54 KB, patch)
2011-12-02 17:50 UTC, Cosimo Cecchi 		committed Details | Review
themingengine: add the arrow-style-type style property (4.46 KB, patch)
2011-12-02 17:50 UTC, Cosimo Cecchi 		none Details | Review

Description Cosimo Cecchi 2011-12-02 17:50:31 UTC 
This patchset reworks arrow rendering by adding an arrow-style-type property to GtkThemingEngine, similar to list-style-type of CSS. See http://www.w3.org/TR/CSS2/generate.html#propdef-list-style for more information.
Comment 1 Cosimo Cecchi 2011-12-02 17:50:34 UTC 
Created attachment 202638 [details] [review]
stylecontext: add GTK_STYLE_CLASS_ARROW

For e.g. submenu items arrow in GtkMenuItems.
Comment 2 Cosimo Cecchi 2011-12-02 17:50:37 UTC 
Created attachment 202639 [details] [review]
stylecontext: always add the ARROW style class when rendering an arrow

When gtk_render_arrow() is called, always add an ARROW style class to
the GtkStyleContext before rendering, so themes can specify a different
color for it.
Comment 3 Cosimo Cecchi 2011-12-02 17:50:41 UTC 
Created attachment 202640 [details] [review]
themingengine: add the arrow-style-type style property

This is in inspiration similar to list-style-type in CSS proper, but
adapted for arrows. Possible values are currently 'arrow' and
'triangle'.
Comment 4 Cosimo Cecchi 2011-12-05 14:47:00 UTC 
Attachment 202638 [details] pushed as c538fb8 - stylecontext: add GTK_STYLE_CLASS_ARROW
Attachment 202639 [details] pushed as d80ff7b - stylecontext: always add the ARROW style class when rendering an arrow

Pushed the first two patches here; there's no consensus the idea from the third patch is actually a good one yet; let's keep it here in the meantime.
Comment 5 Cosimo Cecchi 2012-10-03 17:00:17 UTC 
Renaming this bug; I'm not sure the patch I propose in comment #3 is the best solution, but we need to make this possible somehow.
Comment 6 Matthias Clasen 2013-02-11 06:51:40 UTC 
*** Bug 686986 has been marked as a duplicate of this bug. ***
Comment 7 Matthias Clasen 2014-07-10 03:25:03 UTC 
this has been done now, with -gtk-icon-source