Bug 665409 - statusicon: port to GtkIconHelper
statusicon: port to GtkIconHelper
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkStatusIcon
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2011-12-02 16:07 UTC by Cosimo Cecchi
Modified: 2011-12-05 14:10 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
statusicon: port to GtkIconHelper (19.30 KB, patch)
2011-12-02 16:07 UTC, Cosimo Cecchi 		none Details | Diff | Review
statusicon: port to GtkIconHelper (20.25 KB, patch)
2011-12-02 16:18 UTC, Cosimo Cecchi 		committed Details | Diff | Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Description Cosimo Cecchi 2011-12-02 16:07:56 UTC 
See attached patch. I can't test the Win32 and OSX code paths, but they should work fine.
Comment 1 Cosimo Cecchi 2011-12-02 16:07:58 UTC 
Created attachment 202629 [details] [review]
statusicon: port to GtkIconHelper

Just always render the pixbuf ourselves and set it on the GtkImage in
the X11 case.
Code for other backends was already rendering the pixbuf manually before
translating it into a native type, so this greatly simplifies the code.
Comment 2 Cosimo Cecchi 2011-12-02 16:18:37 UTC 
Created attachment 202631 [details] [review]
statusicon: port to GtkIconHelper

Better patch, plugged a leak and (hopefully) build cleanly on Win32 and OSX too.
Comment 3 Matthias Clasen 2011-12-02 23:35:41 UTC 
I haven't tested this, but I like the overall simplification.
So, if it works ok in your testing, I'd say commit it and solicit some testing 
for win32 and osx.
Comment 4 Cosimo Cecchi 2011-12-05 14:10:34 UTC 
Attachment 202631 [details] pushed as 2e01dc1 - statusicon: port to GtkIconHelper

Thanks, this is pushed to master now.
Note You need to log in before you can comment on or make changes to this bug.