After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 665341 - settings: enable-fullscreen is off
settings: enable-fullscreen is off
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-12-01 21:44 UTC by Philippe Normand
Modified: 2012-01-03 17:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ephy-embed-prefs: Hardcode enable-fullscreen to TRUE (1.01 KB, patch)
2011-12-02 12:10 UTC, Philippe Normand
accepted-commit_now Details | Review
ephy-embed-prefs: Hardcode enable-fullscreen to TRUE (1009 bytes, patch)
2011-12-16 15:07 UTC, Philippe Normand
reviewed Details | Review

Description Philippe Normand 2011-12-01 21:44:59 UTC
Most noticeable effect: Youtube HTML5 videos can't be displayed fullscreen.
Comment 1 Fabio Durán Verdugo 2011-12-02 04:41:16 UTC
Yes I can confirm, I dont know why, but the expand work fine.
Comment 2 Philippe Normand 2011-12-02 09:45:03 UTC
It's simply because some websites use a new fullscreen JS API that allows HTML element to request fullscreen display. WebKitGTK supports this API but it's not enabled at runtime by default.
Comment 3 Philippe Normand 2011-12-02 12:10:55 UTC
Created attachment 202592 [details] [review]
ephy-embed-prefs: Hardcode enable-fullscreen to TRUE

This change is required for websites (like Youtube) using the new
Javascript-based fullscreen API.

Note: It looks bad in WebKitGTK+ 1.7.2. Better wait the next release.

Fixes
Comment 4 Xan Lopez 2011-12-02 12:13:19 UTC
Review of attachment 202592 [details] [review]:

OK, feel free to commit when .3 is out.
Comment 5 Philippe Normand 2011-12-16 14:41:06 UTC
WebKitGTK+ 1.7.3 was released today but ephy still requires 1.6.x. What's the plan about upgrading this requirement? Just to make sure :)
Comment 6 Philippe Normand 2011-12-16 15:07:14 UTC
Created attachment 203679 [details] [review]
ephy-embed-prefs: Hardcode enable-fullscreen to TRUE

This change is required for websites (like Youtube) using the new
Javascript-based fullscreen API.


Now with a check for WebKitGTK+ 1.7.3.
Comment 7 Xan Lopez 2012-01-03 11:51:20 UTC
Review of attachment 203679 [details] [review]:

Just require 1.7.3 in configure.ac, no need for this. Just commit it, no need to upload another patch :)
Comment 8 Philippe Normand 2012-01-03 17:08:01 UTC
commit 9c4a9e1156c56439f1ac500bed216df35754ab1a
Author: Philippe Normand <philn@igalia.com>
Date:   Fri Dec 2 13:07:27 2011 +0100

    ephy-embed-prefs: Hardcode enable-fullscreen to TRUE
    
    This change is required for websites (like Youtube) using the new
    Javascript-based fullscreen API. Also bumped the WebKitGTK requirement
    to 1.7.3 in agreement with Xan. This release includes bug fixes
    related to fullscreen display of videos.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=665341

:)