Created attachment 202543 [details] [review]
Enable X/graphics for Fedora express installation

- Run installer in graphics mode.
- Do install X and GNOME.

Review of attachment 202543 [details] [review]:

::: data/ks.cfg
@@ +26,3 @@
 @core
 @hardware-support
+@X Window System

I suppose it's case insensitive, since "base" and "core" are in minuscule. Perhaps we should keep it consistent.

@@ +27,3 @@
 @hardware-support
+@X Window System
+@GNOME Desktop Environment

isn't it installed by default?

Perhaps we could have a desktop choice somewhere? -> for later?

@@ +32,1 @@
 

it would be awesome to install the current Language group. (based on LC) -> for later?

Review of attachment 202543 [details] [review]:

::: data/ks.cfg
@@ +26,3 @@
 @core
 @hardware-support
+@X Window System

s/minuscule/lowercase

(In reply to comment #2)
> Review of attachment 202543 [details] [review]:
> 
> ::: data/ks.cfg
> @@ +26,3 @@
>  @core
>  @hardware-support
> +@X Window System
> 
> I suppose it's case insensitive, since "base" and "core" are in minuscule.
> Perhaps we should keep it consistent.

I copy&pasted these from the example ks.cfg file at the bottom of this page: http://fedoraproject.org/wiki/Anaconda/Kickstart

> @@ +27,3 @@
>  @hardware-support
> +@X Window System
> +@GNOME Desktop Environment
> 
> isn't it installed by default?

All I know is that w/o this change, X and GNOME are not instaled.
 
> Perhaps we could have a desktop choice somewhere? -> for later?

Express install should just choose the best default settings for an OS and these IMHO are those settings. :) User can always choose to go w/o custom install if he/she wishes to configure more than what we allow.

> @@ +32,1 @@
> 
> 
> it would be awesome to install the current Language group. (based on LC) -> for
> later?

Yeah, that, keyboard layout and timezone are on my TODO.

(In reply to comment #4)
> (In reply to comment #2)
> > Review of attachment 202543 [details] [review] [details]:
> > 
> > ::: data/ks.cfg
> > @@ +26,3 @@
> >  @core
> >  @hardware-support
> > +@X Window System
> > 
> > I suppose it's case insensitive, since "base" and "core" are in minuscule.
> > Perhaps we should keep it consistent.
> 
> I copy&pasted these from the example ks.cfg file at the bottom of this page:
> http://fedoraproject.org/wiki/Anaconda/Kickstart

Actually from the first example here: http://fedoraproject.org/wiki/Anaconda/Kickstart#Chapter_3._Package_Selection

(In reply to comment #4)
> I copy&pasted these from the example ks.cfg file at the bottom of this page:
> http://fedoraproject.org/wiki/Anaconda/Kickstart
> 

Apparently, it's case insensitive. Can we keep it consistent, it's easier to have it all in lowercase.

(In reply to comment #4)
> > Perhaps we could have a desktop choice somewhere? -> for later?
> 
> Express install should just choose the best default settings for an OS and
> these IMHO are those settings. :) User can always choose to go w/o custom
> install if he/she wishes to configure more than what we allow.

Yes, I was thinking in non-express case

(In reply to comment #6)
> (In reply to comment #4)
> > I copy&pasted these from the example ks.cfg file at the bottom of this page:
> > http://fedoraproject.org/wiki/Anaconda/Kickstart
> > 
> 
> Apparently, it's case insensitive. Can we keep it consistent, it's easier to
> have it all in lowercase.

Ok, with this change, ack otherwise?

(In reply to comment #7)
> (In reply to comment #4)
> > > Perhaps we could have a desktop choice somewhere? -> for later?
> > 
> > Express install should just choose the best default settings for an OS and
> > these IMHO are those settings. :) User can always choose to go w/o custom
> > install if he/she wishes to configure more than what we allow.
> 
> Yes, I was thinking in non-express case

This file is only used in case of express installation. :)

Ok, with this change, ack otherwise?

ack

Attachment 202543 [details] pushed as be0eb3a - Enable X/graphics for Fedora express installation