After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 665289 - Build fails with glib 2.31
Build fails with glib 2.31
Status: RESOLVED FIXED
Product: Pan
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: pan-maint
pan-maint
Depends on:
Blocks:
 
 
Reported: 2011-12-01 13:46 UTC by Dominique Leuenberger
Modified: 2011-12-03 08:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix build with glib 2.31 (as much as can be done with pan source) (5.13 KB, patch)
2011-12-01 14:46 UTC, Dominique Leuenberger
none Details | Review
Updated patch: glibconfig.h is actually indirectly included by gtypes.h is included by glib.h (5.11 KB, patch)
2011-12-02 11:27 UTC, Dominique Leuenberger
committed Details | Review

Description Dominique Leuenberger 2011-12-01 13:46:52 UTC
glib 2.31 only allows #include'ing glib.h (and a few exceptions to this).

pan currently imports more that that and fails to build.

Will provide a patch shortly.
Comment 1 Dominique Leuenberger 2011-12-01 14:46:59 UTC
Created attachment 202522 [details] [review]
Fix build with glib 2.31 (as much as can be done with pan source)

Sadly, I just discovered also a bug in glib itself, which does break its own rule of only including glib.h... so from glib 2.31, you will need at least 2.31.3; 2.31.2 will likely never work for you.
Comment 2 Dominique Leuenberger 2011-12-01 16:13:56 UTC
For reference, the glib bug is bug 665293
Comment 3 Dominique Leuenberger 2011-12-02 11:27:24 UTC
Created attachment 202586 [details] [review]
Updated patch: glibconfig.h is actually indirectly included by gtypes.h is included by glib.h
Comment 4 Heinrich Müller 2011-12-03 08:53:25 UTC
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.
Comment 5 Heinrich Müller 2011-12-03 08:56:34 UTC
Up for trial, thanks.
Comment 6 Heinrich Müller 2011-12-03 08:56:56 UTC
Review of attachment 202586 [details] [review]:

Will try, but looks good.