GNOME Bugzilla – Bug 665243
settings: Add support for disabling middle click paste
Last modified: 2013-08-04 09:21:29 UTC
.
Created attachment 202479 [details] [review] settings: Add support for disabling middle click paste
Created attachment 202480 [details] [review] text: Follow gtk-enable-primary-paste setting
NB, untested.
Patch works fine in my testing. Whats the plan here, add an xsetting behind this and set it from gsd ?
(In reply to comment #4) > Patch works fine in my testing. > > Whats the plan here, add an xsetting behind this and set it from gsd ? Yes. Though we need to design the replacement functionality for it before pushing it. See bug 665193 comment 3.
Created attachment 207978 [details] [review] text: Follow gtk-enable-primary-paste setting
Review of attachment 207978 [details] [review]: overall, it looks good to me. ::: gtk/gtkentry.c @@ +3939,3 @@ return TRUE; } + else if (event->button == GDK_BUTTON_MIDDLE && event->type == GDK_BUTTON_PRESS && get_middle_click_paste (entry)) I'd flip this check while we're at it: it makes more sense to check for the event type and then for the event button, then the reverse.
The following fix has been pushed: c1f01eb Add support for disabling middle click paste
Created attachment 213430 [details] [review] Add support for disabling middle click paste Adds a gtk-enable-primary-paste setting that is backed by and X setting, and make GtkEntry and GtkTextView respect it.