GNOME Bugzilla – Bug 665068
Show more information in summary
Last modified: 2016-03-31 14:02:51 UTC
When creating a new VM box, we only show name of OS. Thats just not enough information. We must provide at least the fields shown in the design mockup: https://github.com/gnome-design-team/gnome-mockups/raw/master/boxes/boxes-install5.png
where is the patch? :)
Created attachment 202335 [details] [review] wizard: More details at summary page on VM creation
Created attachment 202342 [details] [review] wizard: More details at summary page on VM creation
Created attachment 202376 [details] [review] wizard: More details at summary page on VM creation
Comment on attachment 202376 [details] [review] wizard: More details at summary page on VM creation Obsoleting in favor of previous patch since after a chat with designers and more thinking, I'll be changing reverting some of the 'live media support' changes.
Review of attachment 202342 [details] [review]: just minor comment about usage of formatting strings for translations. Not even sure if it's really needed. But better safe than sorry ::: src/wizard.vala @@ +124,3 @@ + // Does anyone have < 1M memory? + // Translators: MB here means mega bytes. More information: http://en.wikipedia.org/wiki/Megabyte + return (memory / Osinfo.MEBIBYTES).to_string () + _(" MB"); you might want to use formatting _("%d MB) for languages where the notation is inverted (think of "MB %d") @@ +294,3 @@ + + summary.add_property (_("Memory"), memory_to_string (resources.ram)); + summary.add_property (_("Disk"), memory_to_string (resources.storage) + _(" maximum")); same applies here, better use formatting to let translator choose in which order words come.
Created attachment 202403 [details] [review] wizard: More details at summary page on VM creation
Review of attachment 202403 [details] [review]: ack
Attachment 202403 [details] pushed as ad6370d - wizard: More details at summary page on VM creation
(In reply to comment #6) > ::: src/wizard.vala > @@ +124,3 @@ > + // Does anyone have < 1M memory? > + // Translators: MB here means mega bytes. More information: > http://en.wikipedia.org/wiki/Megabyte > + return (memory / Osinfo.MEBIBYTES).to_string () + _(" MB"); > > you might want to use formatting _("%d MB) for languages where the notation is > inverted (think of "MB %d") Isn't it a good usecase for g_format_size_for_display ?
Make that g_format_size_full(G_FORMAT_SIZE_IEC_UNITS)
(In reply to comment #11) > Make that g_format_size_full(G_FORMAT_SIZE_IEC_UNITS) Good point, I didn't know of g_format_size(). Patch coming..
Created attachment 202411 [details] [review] Make use of GLib.format_size_full() Make use of glib API to format size string to display to user. One advantage is to leave out localization to glib.
Review of attachment 202411 [details] [review]: ack