After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 665052 - The internal effects should queue a repaint on the effect not on the actor when a property changes
The internal effects should queue a repaint on the effect not on the actor wh...
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: ClutterEffect
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2011-11-28 14:45 UTC by Neil Roberts
Modified: 2011-11-28 18:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
effects: Use effect_queue_repaint instead of actor_queue_redraw (3.74 KB, patch)
2011-11-28 14:45 UTC, Neil Roberts 		accepted-commit_now Details | Review

Description Neil Roberts 2011-11-28 14:45:27 UTC 
The builtin effects ClutterColorizeEffect, ClutterDesaturateEffect and
ClutterShaderEffect all have properties which only affect the
rendering of the final texture not the contents of it. When these
properties are updated we should queue a repaint of the effect not
the actor so that we don't waste time repainting the contents of the
offscreen buffer.
Comment 1 Neil Roberts 2011-11-28 14:45:29 UTC 
Created attachment 202296 [details] [review]
effects: Use effect_queue_repaint instead of actor_queue_redraw
Comment 2 Emmanuele Bassi (:ebassi) 2011-11-28 18:00:32 UTC 
Review of attachment 202296 [details] [review]:

looks good to me.
Comment 3 Neil Roberts 2011-11-28 18:38:01 UTC 
Ok, thanks. I've pushed it to master as 627a1b1