After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 665017 - telepathyClient: Fix fallout from Lang.Class port
telepathyClient: Fix fallout from Lang.Class port
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-11-28 09:38 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-01-25 07:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
telepathyClient: Fix fallout from Lang.Class port (2.13 KB, patch)
2011-11-28 09:38 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2011-11-28 09:38:14 UTC 
this.parent was ported from calling the parent class's method like
MessageTray.Notification.prototype._init.call(this, ...);. When
porting to Lang.Class, the 'this' parameter is now passed automatically, but
removing it was forgot in a few places. Fix these places.
Comment 1 Jasper St. Pierre (not reading bugmail) 2011-11-28 09:38:16 UTC 
Created attachment 202277 [details] [review]
telepathyClient: Fix fallout from Lang.Class port
Comment 2 Giovanni Campagna 2011-11-28 14:07:28 UTC 
Review of attachment 202277 [details] [review]:

Looks good
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-01-25 07:13:49 UTC 
Attachment 202277 [details] pushed as 0c19f71 - telepathyClient: Fix fallout from Lang.Class port