After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 665000 - St.Entry destroy send a warning about NULL pointer instance in log
St.Entry destroy send a warning about NULL pointer instance in log
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: st
3.2.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks: 658484
 
 
Reported: 2011-11-28 01:41 UTC by Alban Browaeys
Modified: 2012-01-30 23:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Backtraces of st_im_text behing disposed twice - second time with im_context null (20.99 KB, text/plain)
2011-11-28 01:41 UTC, Alban Browaeys 		  Details
st-im-text: Guard against multiple dispose (1.30 KB, patch)
2011-11-28 01:57 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Alban Browaeys 2011-11-28 01:41:38 UTC 
Created attachment 202266 [details]
Backtraces of st_im_text behing disposed twice - second time with im_context null

I set a breakpoint on st_im_context_dispose . It is called twice . Once by st_entry dispose and then by gjs gc
as st_text_im_dispose unref and nullify its im_context (the im_context ref count stay at one anyway while the st_text_im one is at 5 ) 
the second call try to g_signal_handlers_disconnect_by_func (priv->im_context, while im_context is null
Comment 1 Jasper St. Pierre (not reading bugmail) 2011-11-28 01:57:25 UTC 
Created attachment 202267 [details] [review]
st-im-text: Guard against multiple dispose

This could cause warnings like "invalid (NULL) pointer instance"
Comment 2 Owen Taylor 2012-01-25 16:58:45 UTC 
Review of attachment 202267 [details] [review]:

Looks good
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-01-26 00:04:10 UTC 
Attachment 202267 [details] pushed as f6508b5 - st-im-text: Guard against multiple dispose