GNOME Bugzilla – Bug 664970
Last modified: 2014-05-30 13:33:10 UTC
Created attachment 211466 [details] [review]
Patch for this (and another) bug.
This patch uses the GtkApplication feature, and also introduces the GMenu feature which depends on this.
Review of attachment 211466 [details] [review]:
Sorry, I missed this patch. (Feel free to add comments to the bug, i.e. "why haven't you reviewed my patch!").
It doesn't apply now, can you update it?
Also, in general it is both easier to review and makes it easier to track changes (e.g. looking for regressions) if you just add one feature at a time, i.e. have a GtkApplication patch and a GMenu patch.
Apart from that it is good to go.
We already landed parts of the patch to the sudoku-vala branch. The rest is wip while Chris is finishing his exams.