After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664969 - Use GtkApplication
Use GtkApplication
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: mahjongg
trunk
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks: 664962
 
 
Reported: 2011-11-27 22:57 UTC by Robert Ancell
Modified: 2011-12-22 11:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Mahjongg:Use GtkApplication (1.67 KB, patch)
2011-12-22 06:29 UTC, Sophia Yu
none Details | Review
Mahjongg:Use GtkApplication and remove Gtk.main_quit() (2.32 KB, patch)
2011-12-22 08:01 UTC, Sophia Yu
committed Details | Review

Description Robert Ancell 2011-11-27 22:57:43 UTC
Use GtkApplication
Comment 1 Sophia Yu 2011-12-22 06:29:09 UTC
Created attachment 204070 [details] [review]
Mahjongg:Use GtkApplication

This patch makes Mahjongg use GtkApplication
Comment 2 Sophia Yu 2011-12-22 08:01:06 UTC
Created attachment 204072 [details] [review]
Mahjongg:Use GtkApplication and remove Gtk.main_quit()

This a updated patch to make Mahjongg to use GtkApplication. The previous patch is obsolete.
Comment 3 Robert Ancell 2011-12-22 11:03:23 UTC
Review of attachment 204072 [details] [review]:

You can also remove the 'delete-event' callback - it destroys the window by default so you don't need to catch it.  I've applied this with that change, thanks!