After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664966 - Use GtkApplication
Use GtkApplication
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: gnomine
trunk
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks: 664959
 
 
Reported: 2011-11-27 22:57 UTC by Robert Ancell
Modified: 2011-12-22 11:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
This patch makes gnomine use GtkApplication (1.83 KB, patch)
2011-12-21 06:32 UTC, Sophia Yu 		needs-work Details | Review
Gnomine:Use GtkApplication and remove Gtk.main_quit() (2.50 KB, patch)
2011-12-22 08:08 UTC, Sophia Yu 		committed Details | Review

Description Robert Ancell 2011-11-27 22:57:38 UTC 
Use GtkApplication
Comment 1 Sophia Yu 2011-12-21 06:32:56 UTC 
Created attachment 204017 [details] [review]
This patch makes gnomine use GtkApplication

I just simply followed the changes in Gnotravex.
Comment 2 Robert Ancell 2011-12-21 06:52:45 UTC 
Review of attachment 204017 [details] [review]:

You have an obsolete comment:
+/*public class GnoMine : Gtk.Application*/

Also, you can't use Gtk.main_quit () with GtkApplication, see:
http://git.gnome.org/browse/gnome-games/commit/?id=4f55ff2176c8aae80bee55f84ec3635a8d027d7a
Comment 3 Sophia Yu 2011-12-22 08:08:46 UTC 
Created attachment 204073 [details] [review]
Gnomine:Use GtkApplication and remove Gtk.main_quit()

This a updated patch to make Gnomine to use GtkApplication. The previous patch
is obsolete.
Comment 4 Robert Ancell 2011-12-22 11:05:28 UTC 
Review of attachment 204073 [details] [review]:

Applied with the same change made to the mahjongg patch.  Thanks!