GNOME Bugzilla – Bug 664953
Last modified: 2012-01-30 22:43:56 UTC
Remove statusbar. Move any remaining content (e.g. the clock) into the toolbar or into the game view.
I want to do this task.
Thanks Sophia! Please post status patches into this bug report.
Created attachment 203768 [details] [review]
This patch will remove the status bar and the top and bottom separators
Please take a look at my patch. This is my first Vala-related patch. Basically I just merged the status bar with the New Game button. The flags of the mines is shown at the left of the button, the clock at the right. I also removed the code for creating the top and bottom separators because I thought it looked better than before. I hope I didn't violate any GUI design guide.
Created attachment 203769 [details]
Screenshot of the new GUI
Please check the new GUI with the proposed patch. Thanks!
Review of attachment 203768 [details] [review]:
The patch looks correct, and works well. I agree removing the separators was a good idea.
One minor thing on the patch, in the future can you set the commit comment to "gnomine: ..." so it is clear this patch applies to gnomine and not the other games?
It looks much better already. I've applied the patch, congratulations! There is one more piece of work that can be done if you're interested - to convert the elements at the top into a proper toolbar. You can have a look at how this is done in gnotravex. I'd recommend you make a new game button that has the face as the icon, add a pause button and put the time / flag count on the right.
I don't understand what you meant by the toolbar. Did you mean something like what KMines looks http://en.wikipedia.org/wiki/KMines? Also, I didn't see a toolbar is gnotravex. I'm afraid I'm quite lost.
Created attachment 203840 [details]
Image showing the toolbar in gnotravex
This is the toolbar in gnotravex. Note that it's only in the master version.
Do you plan to do the toolbar change? Any more information required?
Yes. I want to give it a try today or tomorrow. I don't need any more info ATM.
Created attachment 205684 [details] [review]
Add toolbar for Gnomine
I need feedback on how to deal with the face icon, such as where it should be positioned and do we really need it?
Created attachment 205685 [details]
Screenshot of updated Gnomine with the toolbar
Review of attachment 205684 [details] [review]:
What I'd recommend you do is use the face image for the new game button. It's not strictly required that we keep it but it's a fun difference from the standard widgets and a nod to the past of the application. Probably the easiest way to do this is to create a new Gtk.ToolButton and pack the image and "New Game" label into that. Also you should mark the actions as important so the labels show in the toolbar.
Thanks a lot for the suggestions! I will try to improve it.
Created attachment 206399 [details] [review]
This is my second attempt to fix this bug. Also check the attached screenshot
Created attachment 206401 [details]
Review of attachment 206399 [details] [review]:
Great work. I've committed this with a few fixes:
- Marked the new game and hint buttons as important so they have labels
- Don't get the new game button using toolbar.get_nth_item (0) - get it by name
- Some spacing fixes (don't think they were caused by this patch though).