After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664853 - window: Listen for pref changes
window: Listen for pref changes
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2011-11-26 00:58 UTC by Florian Müllner
Modified: 2011-11-26 10:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
window: Listen for pref changes (1.61 KB, patch)
2011-11-26 01:00 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2011-11-26 00:58:34 UTC
See patch.
Comment 1 Florian Müllner 2011-11-26 01:00:20 UTC
Created attachment 202165 [details] [review]
window: Listen for pref changes

The workspaces-only-on-primary preference changes how windows are
displayed, so listen for pref changes and update the visibility
accordingly.
Comment 2 Jasper St. Pierre (not reading bugmail) 2011-11-26 01:08:54 UTC
Review of attachment 202165 [details] [review]:

::: src/core/window.c
@@ +191,3 @@
+  meta_window_update_on_all_workspaces (window);
+
+  meta_window_queue(window, META_QUEUE_CALC_SHOWING);

missing space.
Comment 3 Florian Müllner 2011-11-26 10:35:54 UTC
Attachment 202165 [details] pushed as 497f9be - window: Listen for pref changes

(In reply to comment #2)
> missing space.

Gah, copy+paste :(