After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664850 - Build error: egg-secure-memory.c:1141: 'GKR_SECURE_USE_FALLBACK' undeclared
Build error: egg-secure-memory.c:1141: 'GKR_SECURE_USE_FALLBACK' undeclared
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-11-25 23:23 UTC by André Klapper
Modified: 2011-11-26 07:17 UTC
See Also:
GNOME target: ---
GNOME version: 3.3/3.4

Attachments
Trivial patch (903 bytes, patch)
2011-11-25 23:31 UTC, André Klapper 		none Details | Review

Description André Klapper 2011-11-25 23:23:49 UTC 
In 3f60c65cc0f535362ad6eb77ec08e63c235110e2 GKR_SECURE_USE_FALLBACK was replaced by EGG_SECURE_USE_FALLBACK except for one occurence in /egg/egg-secure-memory.c:1141. This creates a build error when using exotic parameters like "--enable-valgrind=yes":

#ifdef WITH_VALGRIND
/* We like valgrind's warnings, so give it a first whack at checking for errors */
	if (block != NULL || !(flags & GKR_SECURE_USE_FALLBACK))
	VALGRIND_FREELIKE_BLOCK (memory, sizeof (word_t));
#endif
Comment 1 André Klapper 2011-11-25 23:31:31 UTC 
Created attachment 202157 [details] [review]
Trivial patch
Comment 2 Stef Walter 2011-11-26 07:17:13 UTC 
Thanks. Applied to the gnome-3-2 branch of gnome-keyring. Will merge into master soon.