GNOME Bugzilla – Bug 664766
Correctly handle pure live media
Last modified: 2016-03-31 14:02:05 UTC
For pure (no installer) live media: 1. Create transient domain w/o any storage allocation 2. Skip 'Setup' Unfortunately there is no pure live media now a days that I know of so to test this I had to falsely mark fedora media in osinfo db as pure. Next step on live media front would to give a choice to users about what king of box they want to launch.
Created attachment 202092 [details] [review] Throw error from correct place
Created attachment 202093 [details] [review] Improved detection for HW install media Now that we get the ID of the osinfo's media instance that was matched against the HW media, we can use that to get that instance to get more reliable information about media we are dealing with.
Created attachment 202094 [details] [review] Get OS info from purely live real media
Created attachment 202095 [details] [review] Drop redundant params of FedoraInstaller.extract_boot_files
Created attachment 202096 [details] [review] Create transient domains for pure live media For medias that do not provide an installer, we now create and launch a transient domain w/o any storage media.
Created attachment 202097 [details] [review] wizard: Skip 'Setup' for w/ pure live media
Review of attachment 202092 [details] [review]: ack
Review of attachment 202093 [details] [review]: ack
Review of attachment 202094 [details] [review]: ::: src/installer-media.vala @@ +99,3 @@ + if (os_id == null) + os_id = device.get_property ("OSINFO_LIVE"); + I guess you could also use: var os_id = device.get_property ("OSINFO_INSTALLER") ?? device.get_property ("OSINFO_LIVE"); I like the second better, but up to you
Review of attachment 202095 [details] [review]: ack
Review of attachment 202097 [details] [review]: ::: src/wizard.vala @@ +247,3 @@ + // No setup required for pure (no installer) live medias + Idle.add (() => { + page = page + 1; is the idle justified here?
Review of attachment 202096 [details] [review]: ack
(In reply to comment #13) > Review of attachment 202097 [details] [review]: > > ::: src/wizard.vala > @@ +247,3 @@ > + // No setup required for pure (no installer) live medias > + Idle.add (() => { > + page = page + 1; > > is the idle justified here? Perhaps its not really needed at the moment but I'm a bit scared of getting into issues in future for not letting the current page change end first. Anyways, no strong feelings so i can remove it if you like
(In reply to comment #10) > Review of attachment 202094 [details] [review]: > > ::: src/installer-media.vala > @@ +99,3 @@ > + if (os_id == null) > + os_id = device.get_property ("OSINFO_LIVE"); > + > > I guess you could also use: > > var os_id = device.get_property ("OSINFO_INSTALLER") ?? > device.get_property ("OSINFO_LIVE"); > > I like the second better, but up to you Sure!
Attachment 202092 [details] pushed as 76c4627 - Throw error from correct place Attachment 202093 [details] pushed as eed02f2 - Improved detection for HW install media Attachment 202094 [details] pushed as 51a2bcf - Get OS info from purely live real media Attachment 202095 [details] pushed as a6f184c - Drop redundant params of FedoraInstaller.extract_boot_files Attachment 202096 [details] pushed as b6aa23b - Create transient domains for pure live media Attachment 202097 [details] pushed as 24fe4f3 - wizard: Skip 'Setup' for w/ pure live media