After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664690 - wizard: Skip to 'Preparation' when URI is passed
wizard: Skip to 'Preparation' when URI is passed
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-11-24 03:07 UTC by Zeeshan Ali
Modified: 2016-03-31 13:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wizard: Skip to 'Preparation' when URI is passed (936 bytes, patch)
2011-11-24 03:07 UTC, Zeeshan Ali 		committed Details | Review

Description Zeeshan Ali 2011-11-24 03:07:43 UTC 
If a URI has already been passed, we don't need to stay on 'Source' page.
Later when we have reliable-enough means to detect a purely live media, we
can entirely skip 'Setup' page as well.
Comment 1 Zeeshan Ali 2011-11-24 03:07:45 UTC 
Created attachment 202042 [details] [review]
wizard: Skip to 'Preparation' when URI is passed

Skip wizard directly to 'Preparation' step when URI is passed through
commandline argument.
Comment 2 Marc-Andre Lureau 2011-11-24 11:00:14 UTC 
Review of attachment 202042 [details] [review]:

::: src/wizard.vala
@@ +445,3 @@
                 wizard_source.page = SourcePage.URL;
                 wizard_source.uri = app.uri;
+                page = WizardPage.PREPARATION;

looks fine, I guess the "page = WizardPage.SOURCE" above can be removed, but I didn't check carefully
Comment 3 Zeeshan Ali 2011-11-24 13:21:04 UTC 
(In reply to comment #2)
> Review of attachment 202042 [details] [review]:
> 
> ::: src/wizard.vala
> @@ +445,3 @@
>                  wizard_source.page = SourcePage.URL;
>                  wizard_source.uri = app.uri;
> +                page = WizardPage.PREPARATION;
> 
> looks fine, I guess the "page = WizardPage.SOURCE" above can be removed, but I
> didn't check carefully

Thats what I did as first thing but somehow that means getting stuck at 'Preparation' stage.
Comment 4 Zeeshan Ali 2011-11-24 16:31:42 UTC 
Attachment 202042 [details] pushed as 89750ba - wizard: Skip to 'Preparation' when URI is passed