GNOME Bugzilla – Bug 664579
ffmpegcolospace: Support color-matrix for YUV
Last modified: 2012-08-07 10:54:49 UTC
This patch adds support for JPEG color-matrix usage to ffmpegcolorspace. I did not test it, just made sure it compiles. I'm also not sure if there's something that might be broken by adding color-matrix to the caps, though I couldn't come up with a reason. The patch was submitted upstream at https://bugzilla.redhat.com/show_bug.cgi?id=755777 - that URL contains tests.
Created attachment 201944 [details] [review] ffmpegcolospace: Support color-matrix for YUV When the ffmpeg colorspace element supports the color matrix - like with JPEG - make use of it. https://bugzilla.redhat.com/show_bug.cgi?id=755777
The patch looks ok at first glance, but I'm reluctant to push it because it's not obvious to me that all the negotiation stuff will still work correctly here (different transforms, field not present, etc.) So let's just close this. It should already be handled properly in videoconvert in 1.0.