After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664579 - ffmpegcolospace: Support color-matrix for YUV
ffmpegcolospace: Support color-matrix for YUV
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-11-22 17:22 UTC by Benjamin Otte (Company)
Modified: 2012-08-07 10:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ffmpegcolospace: Support color-matrix for YUV (3.20 KB, patch)
2011-11-22 17:22 UTC, Benjamin Otte (Company)
none Details | Review

Description Benjamin Otte (Company) 2011-11-22 17:22:06 UTC
This patch adds support for JPEG color-matrix usage to ffmpegcolorspace. I did not test it, just made sure it compiles. I'm also not sure if there's something that might be broken by adding color-matrix to the caps, though I couldn't come up with a reason.

The patch was submitted upstream at https://bugzilla.redhat.com/show_bug.cgi?id=755777 - that URL contains tests.
Comment 1 Benjamin Otte (Company) 2011-11-22 17:22:08 UTC
Created attachment 201944 [details] [review]
ffmpegcolospace: Support color-matrix for YUV

When the ffmpeg colorspace element supports the color matrix - like with
JPEG - make use of it.

https://bugzilla.redhat.com/show_bug.cgi?id=755777
Comment 2 Tim-Philipp Müller 2012-08-07 10:54:49 UTC
The patch looks ok at first glance, but I'm reluctant to push it because it's not obvious to me that all the negotiation stuff will still work correctly here (different transforms, field not present, etc.)

So let's just close this.

It should already be handled properly in videoconvert in 1.0.