GNOME Bugzilla – Bug 664572
Change e_cal_backend_notify_component* to use ECalComponent
Last modified: 2013-09-14 16:55:35 UTC
I requested from Tristan to use icalcomponent * in new API functions from bug #652180: e_cal_backend_notify_component_created e_cal_backend_notify_components_added e_cal_backend_notify_component_modified e_cal_backend_notify_components_modified e_cal_backend_notify_component_removed but after I tried to use it and also after looking better in the current code I realized that I was wrong, there is no issue with detached instances, they are notified separately, thus using icalcomponent makes only code harder to read and adds more overhead in creating ECalComponent-s from copies of icalcomponents. I'm sorry for my faulty decision here. Let's change this to use ECalComponent-s. Also, drop e_cal_backend_notify_components_added e_cal_backend_notify_components_modified they are unnecessary, their replacement is simple e_data_cal_view_notify_components_added e_data_cal_view_notify_components_modified
OK, it's done now. I cover necessary changes in evolution-exchange, evolution-mapi and evolution-ews as well. II marked the old functions (which were using strings instead of components) as deprecated and replaced their usage in the above mentioned modules and eds itself with their replacements. I also added e_cal_component_new_from_icalcomponent() function, which seemed like a good to have. Created commit 95d7fe1 in eds master (3.3.3+) Created commit 3224821 in eex master (3.3.3+) Created commit 1c4553c in ema master (3.3.3+) Created commit 0ec4fe3 in ews master (3.3.3+)
Erm. forgot to mention evolution-groupwise: Created commit 9954343 in egw master (3.3.3+)