After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664527 - Require latest gtk+ and libvirt-glib
Require latest gtk+ and libvirt-glib
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-11-22 02:35 UTC by Zeeshan Ali
Modified: 2016-03-31 13:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Require latest gtk+ and libvirt-glib (1.05 KB, patch)
2011-11-22 02:35 UTC, Zeeshan Ali
committed Details | Review

Description Zeeshan Ali 2011-11-22 02:35:53 UTC
Please note that this must not be merged before my release patch to
libvirt-glib has been merged.
Comment 1 Zeeshan Ali 2011-11-22 02:35:55 UTC
Created attachment 201892 [details] [review]
Require latest gtk+ and libvirt-glib

- Several people have reported that boxes simply don't work against
  slightly older gtk+ and we know for a fact that UI doesn't look good
  against gtk+ < 0.3.3.
- Latest libvirt-glib is required for domain reconfiguration API, which we
  use now.
Comment 2 Christophe Fergeau 2011-11-22 09:51:43 UTC
Works fine for me with the 3.2 gtk branch, thank you.
Comment 3 Marc-Andre Lureau 2011-11-22 10:57:15 UTC
(In reply to comment #2)
> Works fine for me with the 3.2 gtk branch, thank you.

there is a crasher bug with toolbar item (I can't remember exactly), has it been fixed recenty? Cosimo should know.

But the CSS style is wrong and the result looks quite ugly with 3.2 branch.
Comment 4 Marc-Andre Lureau 2011-11-22 10:57:37 UTC
Review of attachment 201892 [details] [review]:

ack, thanks for the detail comment
Comment 5 Christophe Fergeau 2011-11-22 11:13:26 UTC
(In reply to comment #3)
> there is a crasher bug with toolbar item (I can't remember exactly), has it
> been fixed recenty? Cosimo should know.

It is, http://git.gnome.org/browse/gtk+/commit/?h=gtk-3-2&id=1f23b40b3dcff5a72c2468614021fcb01172d984
Comment 6 Zeeshan Ali 2011-11-22 13:54:39 UTC
Attachment 201892 [details] pushed as 93e4a52 - Require latest gtk+ and libvirt-glib
Comment 7 Christophe Fergeau 2011-11-29 13:07:10 UTC
(In reply to comment #3)

> But the CSS style is wrong and the result looks quite ugly with 3.2 branch.

More details on that? I just tried it with the latest 3.2 tip and things were looking good. Basically I'd set the minimum gtk+ version to gtk 3.2.3