After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664473 - Fix post reboot boot
Fix post reboot boot
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: installer
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-11-21 14:03 UTC by Zeeshan Ali
Modified: 2016-03-31 13:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix post reboot boot (2.28 KB, patch)
2011-11-21 14:03 UTC, Zeeshan Ali 		none Details | Review
Fix post reboot boot (1.81 KB, patch)
2011-11-21 17:56 UTC, Zeeshan Ali 		none Details | Review
Fix post reboot boot (1.68 KB, patch)
2011-11-21 18:16 UTC, Zeeshan Ali 		accepted-commit_now Details | Review
VMCreator should start the created domain (2.70 KB, patch)
2011-11-21 18:20 UTC, Zeeshan Ali 		none Details | Review
Fix post reboot boot (4.06 KB, patch)
2011-11-21 22:37 UTC, Zeeshan Ali 		committed Details | Review

Description Zeeshan Ali 2011-11-21 14:03:51 UTC 
This requires Vir.Connection.redefine_domain() API which is not yet available even
in git master of libvirt-glib.
Comment 1 Zeeshan Ali 2011-11-21 14:03:53 UTC 
Created attachment 201815 [details] [review]
Fix post reboot boot

After the first boot, Don't:

1. use direct boot.
2. boot from cdrom.
Comment 2 Zeeshan Ali 2011-11-21 17:56:27 UTC 
Created attachment 201836 [details] [review]
Fix post reboot boot

After the first boot, Don't:

1. use direct boot.
2. boot from cdrom.
Comment 3 Marc-Andre Lureau 2011-11-21 18:08:29 UTC 
Review of attachment 201836 [details] [review]:

::: src/vm-creator.vala
@@ +33,3 @@
+
+        direct_boot_regex = /<kernel>.*<\/cmdline>/msx;
+        cdrom_boot_regex = /<boot.*dev=.cdrom.\/>/msx;

btw, why do you want to make it a property?

It could be used directly from the replace command.

(I can understand having a static const otherwise, but per isntance, I don't see the point)
Comment 4 Zeeshan Ali 2011-11-21 18:13:24 UTC 
(In reply to comment #3)
> Review of attachment 201836 [details] [review]:
> 
> ::: src/vm-creator.vala
> @@ +33,3 @@
> +
> +        direct_boot_regex = /<kernel>.*<\/cmdline>/msx;
> +        cdrom_boot_regex = /<boot.*dev=.cdrom.\/>/msx;
> 
> btw, why do you want to make it a property?
> 
> It could be used directly from the replace command.

  Just don't want to compile the regex all the time.

> (I can understand having a static const otherwise, but per isntance, I don't
> see the point)

  Yeah, static is more appropriate i guess.
Comment 5 Zeeshan Ali 2011-11-21 18:16:55 UTC 
Created attachment 201841 [details] [review]
Fix post reboot boot

After the first boot, Don't:

1. use direct boot.
2. boot from cdrom.
Comment 6 Zeeshan Ali 2011-11-21 18:20:01 UTC 
Created attachment 201842 [details] [review]
VMCreator should start the created domain
Comment 7 Marc-Andre Lureau 2011-11-21 18:30:50 UTC 
Review of attachment 201841 [details] [review]:

ack
Comment 8 Marc-Andre Lureau 2011-11-21 18:34:43 UTC 
Review of attachment 201842 [details] [review]:

why is it better to have a seperate launch method, instead of create+launch?
Comment 9 Zeeshan Ali 2011-11-21 22:37:26 UTC 
Created attachment 201887 [details] [review]
Fix post reboot boot

After the first boot, Don't:

1. use direct boot.
2. boot from cdrom.
Comment 10 Marc-Andre Lureau 2011-11-21 22:56:44 UTC 
Review of attachment 201887 [details] [review]:

ack
Comment 11 Marc-Andre Lureau 2011-11-21 22:56:45 UTC 
Review of attachment 201887 [details] [review]:

ack
Comment 12 Zeeshan Ali 2011-11-21 23:07:51 UTC 
Attachment 201887 [details] pushed as 0d0dcf8 - Fix post reboot boot