GNOME Bugzilla – Bug 664428
Use GtkGrid instead of GtkBox
Last modified: 2011-11-26 17:30:02 UTC
GtkBox will likely be deprecated soon, so it would be useful to convert uses of GtkBox in Cheese to GtkGrid soon.
Created attachment 202017 [details] [review]
Here is a patch, which should fix this problem. I didn't replace GtkBox of dialogs (because it can only causes problem I suppose?). Tell me if there are any problems :) (maybe I forgot something?)
Thanks for mentoring :)
Created attachment 202048 [details]
screenshot of avatar chooser test
(In reply to comment #1)
> Created an attachment (id=202017) [details] [review]
> Here is a patch, which should fix this problem. I didn't replace GtkBox of
> dialogs (because it can only causes problem I suppose?).
That was the correct thing to do, thanks.
>Tell me if there are
> any problems :) (maybe I forgot something?)
Cheese itself seems fine, but the avatar chooser seems slightly broken. Maybe the CheeseWidget is not set to expand? If you build Cheese, you can find the CheeseAvatarChooser test in tests/cheese-test-chooser. When you run it, you will see that the video preview is very small, as in the attached screenshot. Once that is fixed, I think that the patch is ready to merge.
> Thanks for mentoring :)
Thanks for contributing!
Created attachment 202083 [details] [review]
Ah, yes, I forgot to test this... Here is an updated patch :)
Created attachment 202121 [details]
screenshot of Cheese main window
The avatar chooser works now correctly with the last version of the patch that was submitted, but then, the main window does not display the camara any more. Have a look to the attached screenshot for more details.
Comment on attachment 202083 [details] [review]
Avatar chooser is working fine with this version of the patch, but now the camera is not displayed in the main window. Please, have a look to the screenshot I attached in my last comment
Created attachment 202171 [details] [review]
So, this one should work :)
Comment on attachment 202171 [details] [review]
Pushed to master as commit 4317b88eea3e5f7537a97a5e2714caf252a9f9d6.