After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664360 - Strip a bunch of compat and require libmozjs185
Strip a bunch of compat and require libmozjs185
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2011-11-18 22:54 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2011-11-28 19:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Require mozjs185 (4.87 KB, patch)
2011-11-18 22:54 UTC, Jasper St. Pierre (not reading bugmail) 		none Details | Review
Strip compat.h #define hell (21.65 KB, patch)
2011-11-18 22:54 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
Remove JSFUN_FAST_NATIVE (31.58 KB, patch)
2011-11-18 22:54 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
function: Port to the GJS_NATIVE_CONSTRUCTOR stuff (4.42 KB, patch)
2011-11-18 22:54 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
Require mozjs185 (5.80 KB, patch)
2011-11-26 11:10 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2011-11-18 22:54:25 UTC 
Going forward, I think we want to track upstream libmozjs. Waldo has already
promised me another stable release, so when that arrives we can track that
instead.
Comment 1 Jasper St. Pierre (not reading bugmail) 2011-11-18 22:54:27 UTC 
Created attachment 201687 [details] [review]
Require mozjs185
Comment 2 Jasper St. Pierre (not reading bugmail) 2011-11-18 22:54:29 UTC 
Created attachment 201688 [details] [review]
Strip compat.h #define hell
Comment 3 Jasper St. Pierre (not reading bugmail) 2011-11-18 22:54:31 UTC 
Created attachment 201689 [details] [review]
Remove JSFUN_FAST_NATIVE
Comment 4 Jasper St. Pierre (not reading bugmail) 2011-11-18 22:54:33 UTC 
Created attachment 201690 [details] [review]
function: Port to the GJS_NATIVE_CONSTRUCTOR stuff
Comment 5 Jasper St. Pierre (not reading bugmail) 2011-11-26 11:10:01 UTC 
Created attachment 202176 [details] [review]
Require mozjs185

Strip the JS_PACKAGE/GJS_INTERNALS_LIBS from the .pc files. Apparently PKG_CONFIG_MODULES completely breaks when you have unexpanded variables.
Comment 6 Colin Walters 2011-11-28 19:33:46 UTC 
Review of attachment 201688 [details] [review]:

Looks good.

::: gjs/profiler.c
@@ +155,3 @@
      * figure out the name of the called function.
      */
+    function_name = JS_GetFunctionId(function);;

Extra ;
Comment 7 Colin Walters 2011-11-28 19:34:21 UTC 
Review of attachment 201689 [details] [review]:

Sure.
Comment 8 Colin Walters 2011-11-28 19:41:20 UTC 
Review of attachment 201690 [details] [review]:

Hm...was there a reason function was special cased before?  It looks like I was the last person to touch this code in 7ae2fa5662e327ccd6bdb624ef66bd8edba6659e .

It's odd because if you look at that commit I changed everything except function to use the macros.  If it works, maybe we should just go with it, but looking at this gave me pause.
Comment 9 Colin Walters 2011-11-28 19:43:55 UTC 
Review of attachment 202176 [details] [review]:

I had some thought that when the next mozjs release comes out it might make sense to support it *and* mozjs185, so it would make sense to keep --with-js-package etc, but...eh.  We could just as easily require the latest version.
Comment 10 Jasper St. Pierre (not reading bugmail) 2011-11-28 19:46:16 UTC 
Attachment 201688 [details] pushed as f8d1e99 - Strip compat.h #define hell
Attachment 201689 [details] pushed as b2eb4ec - Remove JSFUN_FAST_NATIVE
Attachment 201690 [details] pushed as 134bb84 - function: Port to the GJS_NATIVE_CONSTRUCTOR stuff
Attachment 202176 [details] pushed as aeb75aa - Require mozjs185