Created attachment 201610 [details] [review]
Reset wizard's source widget after user hits 'Create'

Created attachment 201611 [details] [review]
Only entertain URI commandline argument once

Review of attachment 201611 [details] [review]:

Can app.uri be cleared instead of adding first_launch bool?

Review of attachment 201611 [details] [review]:

Can app.uri be cleared instead of adding first_launch bool?

Review of attachment 201610 [details] [review]:

::: src/wizard-source.vala
@@ +34,3 @@
         get { return url_entry.get_text (); }
+        set {
+            if (value != null)

it's not supposed to be a nullable, I would prefer the empty string which avoid double checks of null & "". You can just assume it's empty or not.

::: src/wizard.vala
@@ +131,3 @@
             install_media = null;
             resources = null;
+            wizard_source.uri = null;

just = ""  is fine then

@@ +132,3 @@
             resources = null;
+            wizard_source.uri = null;
+            wizard_source.page = SourcePage.MAIN;

this should be handled already automatically when you go back to the wizard, we don't need to do it twice. I am affraid it might glitch for a few ms (which you may not notice on fast machine/cases).

(In reply to comment #5)
> @@ +132,3 @@
>              resources = null;
> +            wizard_source.uri = null;
> +            wizard_source.page = SourcePage.MAIN;
> 
> this should be handled already automatically when you go back to the wizard, 

Well, apparently its not. :( The wizard_source stays in URL page once you use that.

Created attachment 201633 [details] [review]
Only entertain URI commandline argument once

Created attachment 201634 [details] [review]
Reset wizard's source widget after user hits 'Create'

Review of attachment 201633 [details] [review]:

::: src/wizard.vala
@@ +436,3 @@
                 wizard_source.page = SourcePage.URL;
                 wizard_source.uri = app.uri;
+                app.uri = null;

can you explain why it should be nullable? I told you why it was easier to have an empty string.

Review of attachment 201633 [details] [review]:

::: src/wizard.vala
@@ +436,3 @@
                 wizard_source.page = SourcePage.URL;
                 wizard_source.uri = app.uri;
+                app.uri = null;

oh, sorry it's not the same property. ok, that makes sense to have it nullable here.

Review of attachment 201634 [details] [review]:

ack

Attachment 201633 [details] pushed as 8f0c80e - Only entertain URI commandline argument once
Attachment 201634 [details] pushed as bd20ce4 - Reset wizard's source widget after user hits 'Create'

(In reply to comment #6)
> (In reply to comment #5)
> > @@ +132,3 @@
> >              resources = null;
> > +            wizard_source.uri = null;
> > +            wizard_source.page = SourcePage.MAIN;
> > 
> > this should be handled already automatically when you go back to the wizard, 
> 
> Well, apparently its not. :( The wizard_source stays in URL page once you use
> that.

This is still the case btw.