After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664288 - dconf update noisy if multiple profile .d files mention the same key
dconf update noisy if multiple profile .d files mention the same key
Status: RESOLVED FIXED
Product: dconf
Classification: Core
Component: dconf
git master
Other Linux
: Normal normal
: ---
Assigned To: dconf-maint
dconf-maint
Depends on:
Blocks:
 
 
Reported: 2011-11-17 17:34 UTC by Ray Strode [halfline]
Modified: 2012-03-19 15:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
dconf update: don't warn on a key set twice (1.31 KB, patch)
2012-03-19 15:09 UTC, Allison Karlitskaya (desrt)
committed Details | Review

Description Ray Strode [halfline] 2011-11-17 17:34:35 UTC
dconf's profile feature supports multiple layers of file overrides.  Right now, if you've got multiple files in one of these profile .d directories and each one specifies the same setting, dconf gets very noisy.  From bug 660660 comment 8 :

/etc/dconf/db/gdm.d/00-upstream-settings: [org/gnome/desktop/session]:
session-name: ignoring duplicate definition of key
/org/gnome/desktop/session/session-name

Apparently, despite this message, the correct behavior still occurs where higher numbered files "win" (according to bug 660660 comment 10 anyway), so this bug is only about muting the message.
Comment 1 Anders Blomdell 2011-11-17 21:05:23 UTC
IMHO it would be even nicer to put all overrides in /etc/dconf/db/<profile.d> and allow the following patterns:

  NN-xx.dconf
Comment 2 Anders Blomdell 2011-11-17 21:08:04 UTC
IMHO it would be even nicer to put all overrides in /etc/dconf/db/<profile.d>
and allow the following patterns:

  NN-xx.dconf
  NN-xx.lock
  NN-xx.unlock

Which would give two benefits:

  1. Possibility to undo upstream lockdowns.
  2. Ignore editor temporary/backup files.
Comment 3 Allison Karlitskaya (desrt) 2012-03-19 15:09:13 UTC
Created attachment 210093 [details] [review]
dconf update: don't warn on a key set twice

It is expected that users may have the same key set multiple times if
they use separate files in an 'override' type of situation.  In this
case the higher-numbered file wins and we should silently ignore the key
set in the lower-numbered file.

This silences the warning message that we previously issued in that
case.
Comment 4 Allison Karlitskaya (desrt) 2012-03-19 15:35:10 UTC
Attachment 210093 [details] pushed as 2bbdd58 - dconf update: don't warn on a key set twice