After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664282 - Adjust shlibs.py to OpenBSD libtool
Adjust shlibs.py to OpenBSD libtool
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other OpenBSD
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-11-17 15:47 UTC by Jasper Lievisse Adriaanse
Modified: 2015-02-07 17:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix giscanner on OpenBSD with non-gnu libtool. (1.10 KB, patch)
2011-11-17 15:47 UTC, Jasper Lievisse Adriaanse
reviewed Details | Review
Adjust to OpenBSD libtool (1.37 KB, patch)
2011-11-18 11:08 UTC, Jasper Lievisse Adriaanse
accepted-commit_now Details | Review

Description Jasper Lievisse Adriaanse 2011-11-17 15:47:18 UTC
Created attachment 201596 [details] [review]
Fix giscanner on OpenBSD with non-gnu libtool.

OpenBSD uses it's own libtool implementation which breaks giscanner in certain situations.

Attached is a patch that adjusts shlibs.py to run ldd on the actual file instead of wrapper script. OK to push this?
Comment 1 Colin Walters 2011-11-17 21:22:55 UTC
Review of attachment 201596 [details] [review]:

This should really be a git format-patch style patch.

::: giscanner/shlibs.py.orig
@@ +74,3 @@
+        # by inserting '.libs/'.
+        old_argdir = binary.args[0]
+        new_libsdir = os.path.dirname(binary.args[0]) + '/.libs/'

Should use:

new_libsdir = os.path.join(os.path.dirname(binary.args[0], '.libs')

Is there a reason it has to end with a trailing / ?
Comment 2 Jasper Lievisse Adriaanse 2011-11-18 11:08:12 UTC
The trailing slash has to be there otherwise it breaks:

ldd: /usr/obj/ports/ethos-0.2.2/ethos-0.2.2/ethos/tmp-introspect5SAeC0/Ethos-1.0                             : not an ELF executable
Error while executing ldd /usr/obj/ports/ethos-0.2.2/ethos-0.2.2/ethos/tmp-intro                             spect5SAeC0/Ethos-1.0
ERROR: can't resolve libraries to shared libraries: ethos-1.0

Attached is a properly formatted patch.
Comment 3 Jasper Lievisse Adriaanse 2011-11-18 11:08:39 UTC
Created attachment 201654 [details] [review]
Adjust to OpenBSD libtool
Comment 4 Jasper Lievisse Adriaanse 2011-11-18 11:10:11 UTC
Argh, forgot to git add before a git commit --amend, anyway, the previous patch does need a trailing '/'. When this is OK I'll push the right diff.
Comment 5 Colin Walters 2011-11-18 23:13:16 UTC
Review of attachment 201654 [details] [review]:

It's not beautiful, but not much of this bit of the code is.  If it works for you, it's fine by me to add.
Comment 6 Jasper Lievisse Adriaanse 2011-11-21 09:45:21 UTC
Thanks.
Comment 7 André Klapper 2015-02-07 17:02:52 UTC
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]